Add rule_id to vulnerability object #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthturner
requested review from
iancardosozup,
lucasbrunozup,
matheusalcantarazup,
nathanmartinszup and
wiliansilvazup
as code owners
matheusalcantarazup
suggested changes
Jan 24, 2022
There was a problem hiding this comment.
Please, follow the Contributing guide to add Developer Certificate of Origin.
Since you make two commit, you can squash them and them add a single DCO.
anthturner
force-pushed
the
add_ruleid_json
branch
2 times, most recently
from
5f05fc3 to
a655818
Compare
Done, thanks. |
|
Hi, @anthturner. Your commit is still missing the
Example: |
Signed-off-by: Anthony Turner <225599+anthturner@users.noreply.github.com>
anthturner
force-pushed
the
add_ruleid_json
branch
from
a655818 to
ea805c1
Compare
|
Sorry, interpreted that as signed as in gpg. Fixed. |
matheusalcantarazup
approved these changes
Jan 24, 2022
nathanmartinszup
approved these changes
Jan 24, 2022
|
Thanks for your contribution @anthturner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added
rule_idfield to JSON generated from Vulnerability object. I also added this back to Swagger since it would be there in the exportHow to verify it
Export to JSON and look at the vulnerability structure
Description for the changelog
Added rule_id to Vulnerability JSON