Overview.md - do not hard-code language of links #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just found the same. |
@kovacs-andras Not supplying a lang attribute will make the link default to english anyways. (e.g. https://docs.horusec.io/docs/web/overview/ - without a language identifier in the path) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Removed the hardcoded lang attribute that would redirect users from the english version of the page to pt-br (brazlian portugese?) target pages.
- How to verify it
Preview the page and see that the generated urls no longer contain the pt-br in the path, but still resolve to the correct page (e.g. english for me).
- Description for the changelog
Documentation: Fix hard-coded languages in links