Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes up-sample script #151

Merged
merged 1 commit into from
Mar 10, 2022
Merged

fixes up-sample script #151

merged 1 commit into from
Mar 10, 2022

Conversation

vniche
Copy link
Contributor

@vniche vniche commented Feb 10, 2022

- What I did

  • updated the postgresql helm parameter (line 29)
  • updated secret key reference (line 33)
  • changed the approach on waiting for postgres to be ready and create analytics database (lines 39 to 42)
  • added secret for confidential client (line 52)

- How to verify it

same old make up-sample

- Description for the changelog
fixes the script to deploy an local development environment

@gitguardian
Copy link

gitguardian bot commented Feb 10, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
Generic High Entropy Secret 1cc7d05 config/samples/sample_install_dependencies.sh 20:29 February 10th, 2022 View secret
Generic High Entropy Secret 1cc7d05 config/samples/sample_install_dependencies.sh 20:29 February 10th, 2022 View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.

 

Our GitHub checks need improvements? Share your feedbacks

@nathanmartinszup nathanmartinszup self-assigned this Feb 15, 2022
@nathanmartinszup
Copy link
Contributor

Hi @vniche.

In order for your pull request to be accepted, your commits must be signed. You can check how to do this in our contribution guide.

Thank you very much for the contribution!

Signed-off-by: Vinicius Niche <viniciusnichecorrea@gmail.com>
@vniche
Copy link
Contributor Author

vniche commented Feb 21, 2022

Hi @vniche.

In order for your pull request to be accepted, your commits must be signed. You can check how to do this in our contribution guide.

Thank you very much for the contribution!

Thanks again @nathanmartinszup, just fixed 👊

@gitguardian
Copy link

gitguardian bot commented Feb 21, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
Generic High Entropy Secret 926c38b config/samples/sample_install_dependencies.sh 00:30 February 21st, 2022 View secret
Generic High Entropy Secret 926c38b config/samples/sample_install_dependencies.sh 00:30 February 21st, 2022 View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.

 

Our GitHub checks need improvements? Share your feedbacks

@nathanmartinszup
Copy link
Contributor

Thank you very much @vniche.

As for the Keycloak values, I believe they are not necessary, as this installation will only use the standard Horusec authentication, not the Keycloak.

@wiliansilvazup wiliansilvazup merged commit f46e1fb into ZupIT:main Mar 10, 2022
@wiliansilvazup
Copy link
Contributor

Thank you very much @vniche.

As for the Keycloak values, I believe they are not necessary, as this installation will only use the standard Horusec authentication, not the Keycloak.

@nathanmartinszup I changed this in my PR #158 :)

@wiliansilvazup
Copy link
Contributor

Thank you very much @vniche for your contribution!

You rock 🚀

nathanmartinszup pushed a commit that referenced this pull request Mar 11, 2022
Signed-off-by: Vinicius Niche <viniciusnichecorrea@gmail.com>
(cherry picked from commit f46e1fb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants