-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes up-sample script #151
Conversation
|
Secret | Commit | Filename | Detected At | |
---|---|---|---|---|
Generic High Entropy Secret | 1cc7d05 | config/samples/sample_install_dependencies.sh | 20:29 February 10th, 2022 | View secret |
Generic High Entropy Secret | 1cc7d05 | config/samples/sample_install_dependencies.sh | 20:29 February 10th, 2022 | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.
Our GitHub checks need improvements? Share your feedbacks
Hi @vniche. In order for your pull request to be accepted, your commits must be signed. You can check how to do this in our contribution guide. Thank you very much for the contribution! |
Signed-off-by: Vinicius Niche <viniciusnichecorrea@gmail.com>
Thanks again @nathanmartinszup, just fixed 👊 |
|
Secret | Commit | Filename | Detected At | |
---|---|---|---|---|
Generic High Entropy Secret | 926c38b | config/samples/sample_install_dependencies.sh | 00:30 February 21st, 2022 | View secret |
Generic High Entropy Secret | 926c38b | config/samples/sample_install_dependencies.sh | 00:30 February 21st, 2022 | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.
Our GitHub checks need improvements? Share your feedbacks
Thank you very much @vniche. As for the Keycloak values, I believe they are not necessary, as this installation will only use the standard Horusec authentication, not the Keycloak. |
@nathanmartinszup I changed this in my PR #158 :) |
Thank you very much @vniche for your contribution! You rock 🚀 |
Signed-off-by: Vinicius Niche <viniciusnichecorrea@gmail.com> (cherry picked from commit f46e1fb)
- What I did
- How to verify it
same old
make up-sample
- Description for the changelog
fixes the script to deploy an local development environment