Bugfix/install script #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 788760 | Generic High Entropy Secret | e4e8037 | config/samples/sample_install_dependencies.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Previously the analytics database is not being created, as the postgresql-client was not waiting for the database pod to be ready. This pull request adds a sleep to avoid this issue. Signed-off-by: Nathan Martins <nathan.martins@zup.com.br>
nathanmartinszup
force-pushed
the
bugfix/install-script
branch
from
970f54f to
e4e8037
Compare
nathanmartinszup
requested review from
wiliansilvazup,
lucasbrunozup,
iancardosozup,
matheusalcantarazup and
oliveirafelipezup
as code owners
wiliansilvazup
approved these changes
Mar 11, 2022
nathanmartinszup
added a commit
that referenced
this pull request
Mar 11, 2022
Previously the analytics database is not being created, as the postgresql-client was not waiting for the database pod to be ready. This pull request adds a sleep to avoid this issue. Signed-off-by: Nathan Martins <nathan.martins@zup.com.br> (cherry picked from commit 8a378cf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How to verify it
- Description for the changelog