auth:chore - Keycloak decode token to get accountID. #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JWTToken call the keycloak server on all requests for backend and this can be considered a DDos attack for keycloak. Signed-off-by: lucas.bruno <lucas.bruno@zup.com.br>
lucasbrunozup
requested review from
iancardosozup,
matheusalcantarazup,
nathanmartinszup and
wiliansilvazup
as code owners
|
| Secret | Commit | Filename | Detected At | |
|---|---|---|---|---|
| Generic High Entropy Secret | bbad3ba | auth/internal/services/authentication/keycloak/client/keycloak_test.go | 12:45 January 12th, 2022 | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.
Our GitHub checks need improvements? Share your feedbacks
matheusalcantarazup
approved these changes
Jan 12, 2022
wiliansilvazup
approved these changes
Jan 12, 2022
nathanmartinszup
approved these changes
Jan 12, 2022
iancardosozup
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the auth verify the user permission, the current code
called keycloak server for get accountID, and this can be
considered a DDos attack for keycloak.
I change the function for the decode the accessToken and
get the accountID from this.
Signed-off-by: lucas.bruno lucas.bruno@zup.com.br