testutils: moved the constants with flags and commands from start_tes…

…t from testutils directory, to reuse in e2e tests.

Signed-off-by: lucas.bruno <lucas.bruno@zup.com.br>

.gitignore

@@ -16,3 +16,4 @@ cmd/horusec/start/examples/
 vendor
 obj/
 /dist
+config/test

e2e/commands/generate/generate_test.go

@@ -16,13 +16,14 @@ package generate_test
 
 import (
 	"fmt"
+	"os"
+	"path/filepath"
+	"strings"
+
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
 	"github.com/onsi/gomega/gbytes"
 	"github.com/onsi/gomega/gexec"
-	"os"
-	"path/filepath"
-	"strings"
 
 	"github.com/ZupIT/horusec/internal/utils/testutil"
 )
@@ -46,9 +47,9 @@ var _ = Describe("Run horusec CLI with generate argument", func() {
 
 	BeforeEach(func() {
 		flags = map[string]string{
-			"--config-file-path": configFilePath,
+			testutil.GlobalFlagConfigFilePath: configFilePath,
 		}
-		cmd := testutil.GinkgoGetHorusecCmdWithFlags(testutil.GenerateCmd, flags)
+		cmd := testutil.GinkgoGetHorusecCmdWithFlags(testutil.CmdGenerate, flags)
 		session, err = gexec.Start(cmd, outBuffer, errBuffer)
 	})
 

e2e/commands/version/version_test.go

@@ -31,7 +31,7 @@ var _ = Describe("Run horusec CLI with version argument", func() {
 	)
 
 	BeforeEach(func() {
-		cmd := testutil.GinkgoGetHorusecCmd(testutil.VersionCmd)
+		cmd := testutil.GinkgoGetHorusecCmd(testutil.CmdVersion)
 		outBuffer = gbytes.NewBuffer()
 		session, err = gexec.Start(cmd, outBuffer, outBuffer)
 	})

e2e/scan/scan_test.go

@@ -21,6 +21,8 @@ import (
 	"os"
 	"path"
 
+	"github.com/ZupIT/horusec/internal/enums/outputtype"
+
 	"github.com/google/uuid"
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
@@ -127,12 +129,12 @@ var _ = Describe("Scan vulnerabilities example folder", func() {
 			output := path.Join(os.TempDir(), fmt.Sprintf("horusec-analysis-%s.json", uuid.New().String()))
 
 			flags := map[string]string{
-				"-p": tt.target,
-				"-o": "json",
-				"-O": output,
+				testutil.StartFlagProjectPath:        tt.target,
+				testutil.StartFlagOutputFormat:       outputtype.JSON,
+				testutil.StartFlagJsonOutputFilePath: output,
 			}
 
-			cmd := testutil.GinkgoGetHorusecCmdWithFlags(testutil.StartCmd, flags)
+			cmd := testutil.GinkgoGetHorusecCmdWithFlags(testutil.CmdStart, flags)
 
 			stdout := bytes.NewBufferString("")
 			stderr := bytes.NewBufferString("")

internal/utils/file/file_test.go

@@ -18,8 +18,9 @@ import (
 	"path/filepath"
 	"testing"
 
-	"github.com/ZupIT/horusec/internal/utils/testutil"
 	"github.com/stretchr/testify/assert"
+
+	"github.com/ZupIT/horusec/internal/utils/testutil"
 )
 
 func TestGetFilePathIntoBasePath(t *testing.T) {

internal/utils/testutil/binary.go

@@ -24,27 +24,15 @@ import (
 	"github.com/onsi/ginkgo"
 )
 
-type HorusecCmd string
-
-func (h HorusecCmd) String() string {
-	return string(h)
-}
-
-const (
-	VersionCmd  HorusecCmd = "version"
-	StartCmd    HorusecCmd = "start"
-	GenerateCmd HorusecCmd = "generate"
-)
-
-func GinkgoGetHorusecCmd(horusecCmd HorusecCmd) *exec.Cmd {
+func GinkgoGetHorusecCmd(horusecCmd string) *exec.Cmd {
 	bin := ginkgoBuildHorusecBinary()
-	args := setLogLevelArgsToHorusecCmd(horusecCmd.String())
+	args := setLogLevelArgsToHorusecCmd(horusecCmd)
 	return exec.Command(bin, args...)
 }
 
-func GinkgoGetHorusecCmdWithFlags(cmdArg HorusecCmd, flags map[string]string) *exec.Cmd {
+func GinkgoGetHorusecCmdWithFlags(cmdArg string, flags map[string]string) *exec.Cmd {
 	bin := ginkgoBuildHorusecBinary()
-	args := setLogLevelArgsToHorusecCmd(cmdArg.String())
+	args := setLogLevelArgsToHorusecCmd(cmdArg)
 	for flag, value := range flags {
 		args = append(args, fmt.Sprintf("%s=%s", flag, value))
 	}

internal/utils/testutil/cliArgs.go

@@ -0,0 +1,74 @@
+// Copyright 2020 ZUP IT SERVICOS EM TECNOLOGIA E INOVACAO SA
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package testutil
+
+// Available Commands
+const (
+	CmdVersion  = "version"
+	CmdStart    = "start"
+	CmdGenerate = "generate"
+)
+
+// Available Global Flags
+const (
+	GlobalFlagConfigFilePath = "--config-file-path"
+	GlobalFlagHelp           = "--help"
+	GlobalFlagLogFilePath    = "--log-file-path"
+	GlobalFlagLogLevel       = "--log-level"
+)
+
+// Available Flags for start command
+const (
+	StartFlagAnalysisTimeout            = "--analysis-timeout"
+	StartFlagAuthorization              = "--authorization"
+	StartFlagCertificatePath            = "--certificate-path"
+	StartFlagContainerBindProjectPath   = "--container-bind-project-path"
+	StartFlagCustomRulesPath            = "--custom-rules-path"
+	StartFlagDisableDocker              = "--disable-docker"
+	StartFlagEnableCommitAuthor         = "--enable-commit-author"
+	StartFlagEnableGitHistory           = "--enable-git-history"
+	StartFlagEnableOwaspDependencyCheck = "--enable-owasp-dependency-check"
+	StartFlagEnableShellcheck           = "--enable-shellcheck"
+	StartFlagFalsePositive              = "--false-positive"
+	StartFlagHeaders                    = "--headers"
+	StartFlagHorusecURL                 = "--horusec-url"
+	StartFlagIgnore                     = "--ignore"
+	StartFlagIgnoreSeverity             = "--ignore-severity"
+	StartFlagInformationSeverity        = "--information-severity"
+	StartFlagInsecureSkipVerify         = "--insecure-skip-verify"
+	StartFlagJSONOutputFilePath         = "--json-output-file"
+	StartFlagMonitorRetryCount          = "--monitor-retry-count"
+	StartFlagOutputFormat               = "--output-format"
+	StartFlagProjectPath                = "--project-path"
+	StartFlagRepositoryName             = "--repository-name"
+	StartFlagRequestTimeout             = "--request-timeout"
+	StartFlagReturnError                = "--return-error"
+	StartFlagRiskAccept                 = "--risk-accept"
+	StartFlagShowVulnerabilitiesTypes   = "--show-vulnerabilities-types"
+)
+
+func GetAllStartFlags() []string {
+	return []string{
+		StartFlagAnalysisTimeout, StartFlagAuthorization, StartFlagCertificatePath,
+		StartFlagContainerBindProjectPath, StartFlagCustomRulesPath, StartFlagDisableDocker,
+		StartFlagEnableCommitAuthor, StartFlagEnableGitHistory, StartFlagEnableOwaspDependencyCheck,
+		StartFlagEnableShellcheck, StartFlagFalsePositive, StartFlagHeaders,
+		StartFlagHorusecURL, StartFlagIgnore, StartFlagIgnoreSeverity,
+		StartFlagInformationSeverity, StartFlagInsecureSkipVerify, StartFlagJSONOutputFilePath,
+		StartFlagMonitorRetryCount, StartFlagOutputFormat, StartFlagProjectPath,
+		StartFlagRepositoryName, StartFlagRequestTimeout, StartFlagReturnError,
+		StartFlagRiskAccept, StartFlagShowVulnerabilitiesTypes,
+	}
+}