You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What would you like to be added: When we validate the docker requirements we use exec.Command to execute docker commands and check if docker is running and if it's on minimum version required. Although it works well, a better approach would be to use the client from NewDockerClient and use the method Ping to check version and verify if the daemon is running.
Why is this needed:
Since we are using different approaches to execute docker commands, we can have inconsistency when running them. Before #756 get merged when we set the DOCKER_HOST env the requirements execute successfully (the docker cli read env correctly) but when we start the containers we get errors because we was using an client without reading the environment variables.
The text was updated successfully, but these errors were encountered:
I managed to get the version with the dockerClient.ServerVersion. How the error log of the function execDockerVersion from the file docker.go has to be formatted?
The exec.Command returns the response bytes when occurs an error.
The dockerClient.ServerVersion returns an empty types.Version struct.
The errors.New expects a string.
What would you like to be added:
When we validate the docker requirements we use
exec.Command
to execute docker commands and check if docker is running and if it's on minimum version required. Although it works well, a better approach would be to use the client fromNewDockerClient
and use the methodPing
to check version and verify if the daemon is running.Why is this needed:
Since we are using different approaches to execute docker commands, we can have inconsistency when running them. Before #756 get merged when we set the
DOCKER_HOST
env the requirements execute successfully (the docker cli read env correctly) but when we start the containers we get errors because we was using an client without reading the environment variables.The text was updated successfully, but these errors were encountered: