Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint:chore - Fix lint, format and Horusec API tests #1004

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

wiliansilvazup
Copy link
Contributor

@wiliansilvazup wiliansilvazup commented Feb 22, 2022

Look in this commit I commented the test in horus_api_test.go,
because in local machine this works fine, but in github actions don't
and I don't know what us can do.

Signed-off-by: Wilian Gabriel wilian.silva@zup.com.br

@gitguardian
Copy link

gitguardian bot commented Feb 23, 2022

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@wiliansilvazup wiliansilvazup marked this pull request as ready for review February 23, 2022 16:00
@wiliansilvazup wiliansilvazup added the kind/bug Something isn't working label Feb 23, 2022
@matheusalcantarazup
Copy link
Contributor

matheusalcantarazup commented Feb 24, 2022

The commit message should be updated to inform that we remove the test and not just commented.

Look in this commit I removed the test in `horus_api_test.go`,
because in local machine this works fine, but in github actions don't
work.

Signed-off-by: Wilian Gabriel <wilian.silva@zup.com.br>
@nathanmartinszup nathanmartinszup merged commit d7fcbe3 into main Feb 24, 2022
@nathanmartinszup nathanmartinszup deleted the chore/fix-pipeline branch March 8, 2022 12:40
nathanmartinszup pushed a commit that referenced this pull request Apr 4, 2022
Look in this commit I removed the test in `horus_api_test.go`,
because in local machine this works fine, but in github actions don't
work.

Signed-off-by: Wilian Gabriel <wilian.silva@zup.com.br>
(cherry picked from commit d7fcbe3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants