analyzer:bugfix - separate warnings from errors #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both errors and warnings are handled using the same field, this causes a lot of confusion and a very complex code. This pull request removes warnings from the errors field, and adds them to the specific field for warnings. In the future with the refactoring of formaters this code can be removed, but for now it is a necessary workaround. Signed-off-by: Nathan Martins <nathan.martins@zup.com.br>
nathanmartinszup
requested review from
wiliansilvazup,
matheusalcantarazup,
lucasbrunozup and
iancardosozup
as code owners
This was referenced Mar 4, 2022
iancardosozup
approved these changes
Mar 4, 2022
matheusalcantarazup
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both errors and warnings are handled using the same field, this causes a
lot of confusion and a very complex code.
This pull request removes warnings from the errors field, and adds them
to the specific field for warnings. In the future with the refactoring
of formaters this code can be removed, but for now it is a necessary
workaround.
Signed-off-by: Nathan Martins nathan.martins@zup.com.br
- What I did
- How to verify it
- Description for the changelog