formatters:chore - normalize not found files warn message #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
requested review from
wiliansilvazup,
lucasbrunozup,
nathanmartinszup,
iancardosozup and
oliveirafelipezup
as code owners
Previously the warning messages of files that was not found to execute
an analysis was different between formatters, and also the prefix
{HORUSEC_CLI} was being added on the middle of the message and not the
start.
This commit normalize these messages to have the same content for all
formatters and the {HORUSEC_CLI} prefix was fixed by adding on the start
of the message like all other log messages. A strings.ReplaceAll was
also added to remove the `;` suffix on these warning messages since
the commit 345c748 change these messages from errors to warnings (
strings.ReplaceAll already exists to remove `;`from error messages).
The warn message of gemfile.lock file not found was removed since it
was not being used by any formatter.
Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup
force-pushed
the
improve-warn-messages
branch
from
b48a23c to
7c56148
Compare
nathanmartinszup
approved these changes
Mar 10, 2022
iancardosozup
approved these changes
Mar 10, 2022
nathanmartinszup
pushed a commit
that referenced
this pull request
Mar 10, 2022
Previously the warning messages of files that was not found to execute
an analysis was different between formatters, and also the prefix
{HORUSEC_CLI} was being added on the middle of the message and not the
start.
This commit normalize these messages to have the same content for all
formatters and the {HORUSEC_CLI} prefix was fixed by adding on the start
of the message like all other log messages. A strings.ReplaceAll was
also added to remove the `;` suffix on these warning messages since
the commit 345c748 change these messages from errors to warnings (
strings.ReplaceAll already exists to remove `;`from error messages).
The warn message of gemfile.lock file not found was removed since it
was not being used by any formatter.
Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
(cherry picked from commit d1be5f9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the warning messages of files that was not found to execute
an analysis was different between formatters, and also the prefix
{HORUSEC_CLI} was being added on the middle of the message and not the
start.
This commit normalize these messages to have the same content for all
formatters and the {HORUSEC_CLI} prefix was fixed by adding on the start
of the message like all other log messages. A strings.ReplaceAll was
also added to remove the
;suffix on these warning messages sincethe commit 345c748 change these messages from errors to warnings (
strings.ReplaceAll already exists to remove
;from error messages).The warn message of gemfile.lock file not found was removed since it
was not being used by any formatter.