Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/trivy #504

Merged
merged 27 commits into from
Aug 5, 2021
Merged

Feature/trivy #504

merged 27 commits into from
Aug 5, 2021

Conversation

iancardosozup
Copy link
Contributor

- What I did
Add trivy as new tool for analysis
- How to verify it
horusec start
- Description for the changelog
Add trivy as new tool for changelog

matheusalcantarazup and others added 22 commits June 9, 2021 08:20
* fix possible wrong path concat on windows

* enable data race detection on make test

* fix data-races when running analysis

Previously when we start an analysis of language/tool we controlled the
state of execution using the monitor package, but many objects use the
same instance of monitor doing updates and reads concurrent resulting
in possible data races. This commit drops the monitor package and replace
to use the `sync.WaitGroup` to control the state of go routines.
An improvement was also made to control the timeout of analysis using
`time.After` function to receive the channel when timeout occurred or close
the `done` channel when analysis finish. An mutex was added on Service
to avoid data races when adding errors on Analysis.
* Adding owasp dependency check formatter

* Adding tests and fixing lint

* Adding flag to enable owasp dependency check

* Fixing pipeline errors

* Fixing some errors

* Updating devkit version
* Adding dotnet cli dependency check

* Fixing lint errors

* Adding lisence header

* Improving security code scan

* Adding validation to not found solution in scs, adding license headers

* Adding code in security code scan

* Updating csharp example with vulnerable dependencies, adding validation to failed build in security code scan

* Fixing some errors

* Adding code, line and filepath in dotnet cli. Fixing some errors

* Updating horusec json

* Fixing commit authors issues

* Fixing some issues found during tests

* Adding validation to dotnetcli output

* Fixing lint error

* Fixing lint errors

* Fixing lint error

* Updating horusec config json

* Updating go modules and adding missing unity test

* Fixing error to remove .horusec
Previously, to warn the user that the analysis is still running, we used
time.Sleep to print how much time is left for the timeout, however, if the
analysis has already been completed, we still need to wait for the end of
time.Sleep to finish the analysis. This change removes time.Sleep and uses
time.Tick to print the message, so, if the analysis is finished before the
next retry, we do not lock the analysis with time.Sleep.
* Adding nancy dependency check for go

* Adding nancy unity tests

* Adding vulnerable dependencies in go example project

* Fixing errors found during tests

* Fixing unity tests and pipeline errors

* Updating devkit version

* Fixing pipeline errors

* Updating go dockerfile to use nancy binary from github
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
Signed-off-by: nathanmartinszup <nathan.martins@zup.com.br>
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
@matheusalcantarazup
Copy link
Contributor

Please, rebase this branch with develop to void conflicts and merge commits

@wiliansilvazup wiliansilvazup merged commit f92efcc into develop Aug 5, 2021
@wiliansilvazup wiliansilvazup deleted the feature/trivy branch August 5, 2021 13:20
This was referenced Aug 9, 2021
wiliansilvazup added a commit that referenced this pull request Aug 9, 2021
* fix data-races when running analysis (#477)

* fix possible wrong path concat on windows

* enable data race detection on make test

* fix data-races when running analysis

Previously when we start an analysis of language/tool we controlled the
state of execution using the monitor package, but many objects use the
same instance of monitor doing updates and reads concurrent resulting
in possible data races. This commit drops the monitor package and replace
to use the `sync.WaitGroup` to control the state of go routines.
An improvement was also made to control the timeout of analysis using
`time.After` function to receive the channel when timeout occurred or close
the `done` channel when analysis finish. An mutex was added on Service
to avoid data races when adding errors on Analysis.

* improvement on Swift rules description (#479)

* feature/dependency-check (#478)

* Adding owasp dependency check formatter

* Adding tests and fixing lint

* Adding flag to enable owasp dependency check

* Fixing pipeline errors

* Fixing some errors

* Updating devkit version

* Feature/dotnet cli (#480)

* Adding dotnet cli dependency check

* Fixing lint errors

* Adding lisence header

* Improving security code scan

* Adding validation to not found solution in scs, adding license headers

* Adding code in security code scan

* Updating csharp example with vulnerable dependencies, adding validation to failed build in security code scan

* Fixing some errors

* Adding code, line and filepath in dotnet cli. Fixing some errors

* Updating horusec json

* Fixing commit authors issues

* Fixing some issues found during tests

* Adding validation to dotnetcli output

* Fixing lint error

* Fixing lint errors

* Fixing lint error

* Updating horusec config json

* Updating go modules and adding missing unity test

* Fixing error to remove .horusec

* [skip ci] Update versioning file

* avoid time.Sleep to log analysis timeout status (#482)

Previously, to warn the user that the analysis is still running, we used
time.Sleep to print how much time is left for the timeout, however, if the
analysis has already been completed, we still need to wait for the end of
time.Sleep to finish the analysis. This change removes time.Sleep and uses
time.Tick to print the message, so, if the analysis is finished before the
next retry, we do not lock the analysis with time.Sleep.

* Feature/nancy (#483)

* Adding nancy dependency check for go

* Adding nancy unity tests

* Adding vulnerable dependencies in go example project

* Fixing errors found during tests

* Fixing unity tests and pipeline errors

* Updating devkit version

* Fixing pipeline errors

* Updating go dockerfile to use nancy binary from github

* Add set log file to global command
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

* Add set log file to global command
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

* remove ctrl v error

Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

* refactor cyclomatic function

Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

* Fixing lint errors

Signed-off-by: nathanmartinszup <nathan.martins@zup.com.br>

* fix tests

Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

* Add LogOutput Tests

Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

* Fix tests

Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

* altering fileName creation to use filepath.Join

Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

* removing comments from tests

Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

* Change logpath flage name to log-file-path and refactor on logSetOutput

* Adding more tests and system call interface

Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

* Save work

Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

* fix viper config

Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

* Add trivy as new tool to generic analyzers

Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>

* Att gomod and add setSystemCall

* Add license to trivy files

* Fix tools to ignore from merge commit error

Co-authored-by: matheusalcantarazup <84723211+matheusalcantarazup@users.noreply.github.com>
Co-authored-by: nathanmartinszup <63246935+nathanmartinszup@users.noreply.github.com>
Co-authored-by: wilian <wilian.silva@zup.com.br>
Co-authored-by: nathanmartinszup <nathan.martins@zup.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants