Added tests for HS-JAVA-134 rule #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
dearrudam
requested review from
iancardosozup,
lucasbrunozup,
matheusalcantarazup,
nathanmartinszup and
wiliansilvazup
as code owners
matheusalcantarazup
suggested changes
Oct 19, 2021
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
dearrudam
commented
Oct 19, 2021
matheusalcantarazup
approved these changes
Oct 19, 2021
|
LGTM. I'ill squash these two commits into a single one but on the next PRS considering amend commit changes instead add new ones. It's better to have single atomic commits with all the changes instead a lot of small commits, is more easily to go back if we want. |
|
@matheusalcantarazup thanks for your support!!! I'll consider amending commit changes in the next PRs!!! I'm a continuous learner, so, thanks for this opportunity to learn!!! |
matheusalcantarazup
pushed a commit
that referenced
this pull request
Oct 28, 2021
rules: add tests for HS-JAVA-134 rule Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
matheusalcantarazup
pushed a commit
that referenced
this pull request
Oct 28, 2021
rules: add tests for HS-JAVA-134 rule Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
matheusalcantarazup
pushed a commit
that referenced
this pull request
Oct 28, 2021
rules: add tests for HS-JAVA-134 rule Signed-off-by: Maximillian Arruda <dearrudam@gmail.com> (cherry picked from commit b6e7899)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maximillian Arruda dearrudam@gmail.com
- What I did : I followed the issue (#630) description;
- How to verify it: I should execute the tests by make test;
- Description for the changelog: Cover the HS-JAVA-134;