Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for nginx rules using horusec-engine #705

Merged
merged 1 commit into from
Oct 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions internal/services/engines/nginx/rules_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,20 @@ import (

func TestRulesVulnerableCode(t *testing.T) {
testcases := []*testutil.RuleTestCase{
{
Name: "HS-NGINX-1",
Rule: NewIncludeXFrameOptionsHeader(),
Src: SampleVulnerableIncludeXFrameOptionsHeader,
Findings: []engine.Finding{
{
CodeSample: "",
SourceLocation: engine.Location{
Line: 0,
Column: 0,
},
},
},
},
{
Name: "HS-NGINX-2",
Rule: NewIncludeXContentTypeOptionsHeader(),
Expand All @@ -37,18 +51,61 @@ func TestRulesVulnerableCode(t *testing.T) {
},
},
},
{
Name: "HS-NGINX-3",
Rule: NewIncludeContentSecurityPolicyHeader(),
Src: SampleVulnerableIncludeContentSecurityPolicyHeader,
Findings: []engine.Finding{
{
CodeSample: "",
SourceLocation: engine.Location{
Line: 0,
Column: 0,
},
},
},
},
{
Name: "HS-NGINX-4",
Rule: NewIncludeServerTokensOff(),
Src: SampleVulnerableIncludeServerTokensOff,
Findings: []engine.Finding{
{
CodeSample: "",
SourceLocation: engine.Location{
Line: 0,
Column: 0,
},
},
},
},
}

testutil.TestVulnerableCode(t, testcases)
}

func TestRulesSafeCode(t *testing.T) {
testcases := []*testutil.RuleTestCase{
{
Name: "HS-NGINX-1",
Rule: NewIncludeXFrameOptionsHeader(),
Src: SampleSafeIncludeXFrameOptionsHeader,
},
{
Name: "HS-NGINX-2",
Rule: NewIncludeXContentTypeOptionsHeader(),
Src: SampleSafeIncludeXContentTypeOptionsHeader,
},
{
Name: "HS-NGINX-3",
Rule: NewIncludeContentSecurityPolicyHeader(),
Src: SampleSafeIncludeContentSecurityPolicyHeader,
},
{
Name: "HS-NGINX-4",
Rule: NewIncludeServerTokensOff(),
Src: SampleSafeIncludeServerTokensOff,
},
}

testutil.TestSafeCode(t, testcases)
Expand Down
44 changes: 44 additions & 0 deletions internal/services/engines/nginx/samples_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,50 @@ add_header Strict-Transport-Security "max-age=15768000; includeSubDomains";
add_header X-XSS-Protection "1; mode=block";
add_header X-Content-Type-Options "nosniff";
add_header Content-Security-Policy "default-src 'self'; img-src *; style-src 'self' 'unsafe-inline'; script-src 'self' 'unsafe-inline' 'unsafe-eval'";
upstream plone52 {
server 127.0.0.1:8080;
}`
SampleVulnerableIncludeXFrameOptionsHeader = `
add_header Strict-Transport-Security "max-age=15768000; includeSubDomains";
add_header X-XSS-Protection "1; mode=block";
add_header Content-Security-Policy "default-src 'self'; img-src *; style-src 'self' 'unsafe-inline'; script-src 'self' 'unsafe-inline' 'unsafe-eval'";
upstream plone52 {
server 127.0.0.1:8080;
}`
SampleSafeIncludeXFrameOptionsHeader = `
add_header X-Frame-Options "SAMEORIGIN";
add_header Strict-Transport-Security "max-age=15768000; includeSubDomains";
add_header X-XSS-Protection "1; mode=block";
add_header Content-Security-Policy "default-src 'self'; img-src *; style-src 'self' 'unsafe-inline'; script-src 'self' 'unsafe-inline' 'unsafe-eval'";
upstream plone52 {
server 127.0.0.1:8080;
}`
SampleVulnerableIncludeContentSecurityPolicyHeader = `
add_header Strict-Transport-Security "max-age=15768000; includeSubDomains";
add_header X-XSS-Protection "1; mode=block";
upstream plone52 {
server 127.0.0.1:8080;
}`
SampleSafeIncludeContentSecurityPolicyHeader = `
add_header X-Frame-Options "SAMEORIGIN";
add_header Strict-Transport-Security "max-age=15768000; includeSubDomains";
add_header X-XSS-Protection "1; mode=block";
add_header Content-Security-Policy "default-src 'self'; img-src *; style-src 'self' 'unsafe-inline'; script-src 'self' 'unsafe-inline' 'unsafe-eval'";
upstream plone52 {
server 127.0.0.1:8080;
}`
SampleVulnerableIncludeServerTokensOff = `
add_header Strict-Transport-Security "max-age=15768000; includeSubDomains";
add_header X-XSS-Protection "1; mode=block";
upstream plone52 {
server 127.0.0.1:8080;
}`
SampleSafeIncludeServerTokensOff = `
server_tokens off;
add_header X-Frame-Options "SAMEORIGIN";
add_header Strict-Transport-Security "max-age=15768000; includeSubDomains";
add_header X-XSS-Protection "1; mode=block";
add_header Content-Security-Policy "default-src 'self'; img-src *; style-src 'self' 'unsafe-inline'; script-src 'self' 'unsafe-inline' 'unsafe-eval'";
upstream plone52 {
server 127.0.0.1:8080;
}`
Expand Down