engine: improving rule and adding tests for java 1, 3, 4 #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Martins <nathan.martins@zup.com.br>
nathanmartinszup
requested review from
iancardosozup,
lucasbrunozup,
matheusalcantarazup and
wiliansilvazup
as code owners
wiliansilvazup
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nathan Martins nathan.martins@zup.com.br
- What I did
HS-JAVA-1, HS-JAVA-3 and HS-JAVA-4 were taking both secure and vulnerable code, added new regex to avoid false positives. Also added vulnerable, safe samples and tests.
Samples:
HS-JAVA-1: https://find-sec-bugs.github.io/bugs.htm#XXE_XMLREADER
HS-JAVA-3: https://find-sec-bugs.github.io/bugs.htm#XXE_DOCUMENT
HS-JAVA-4: https://find-sec-bugs.github.io/bugs.htm#XXE_SAXPARSER
- How to verify it
- Description for the changelog