Adding tests for rules 7-17 of dart language #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiliansilvazup
requested review from
iancardosozup,
lucasbrunozup,
matheusalcantarazup and
nathanmartinszup
as code owners
wiliansilvazup
force-pushed
the
feature/dart-rules-7-17
branch
from
48eb025 to
fe1933c
Compare
wiliansilvazup
changed the title
wiliansilvazup
force-pushed
the
feature/dart-rules-7-17
branch
from
fe1933c to
85c3ca1
Compare
nathanmartinszup
approved these changes
Oct 25, 2021
wiliansilvazup
force-pushed
the
feature/dart-rules-7-17
branch
from
85c3ca1 to
2b06fef
Compare
iancardosozup
approved these changes
Oct 25, 2021
wiliansilvazup
force-pushed
the
feature/dart-rules-7-17
branch
from
2b06fef to
66c4dca
Compare
Note that in the HS-DART-8 rule, I increased the accuracy of the rule to only get logs that have string concatenation or string format. Note too the HS-DART-15 rule was not working because there is no capitalized property so I added the option to include it in the entire regular expression. Signed-off-by: wilian <wilian.silva@zup.com.br>
wiliansilvazup
force-pushed
the
feature/dart-rules-7-17
branch
from
66c4dca to
4488f18
Compare
matheusalcantarazup
suggested changes
Oct 27, 2021
i'll open other PR change all Constants names |
matheusalcantarazup
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that in the HS-DART-8 rule, I increased the accuracy of the rule to only get logs that have string concatenation or string format.
Note too the HS-DART-15 rule was not working because there is no capitalized property so I added the option to include it in the entire regular expression.
Signed-off-by: wilian wilian.silva@zup.com.br