utils/copy:chore - skip symlink files and improve tests assertiveness #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
matheusalcantarazup
force-pushed
the
copy-tests
branch
from
46ceded to
5c51e9e
Compare
matheusalcantarazup
changed the title
matheusalcantarazup
force-pushed
the
copy-tests
branch
from
5c51e9e to
79798f6
Compare
matheusalcantarazup
force-pushed
the
copy-tests
branch
from
79798f6 to
d9dfe13
Compare
Previously if some symlink exists on project path during the copy we was creating a directory instead evaluating the sysmlink. Evaluating the symlink makes us need to deal with several scenarios, such as, how should we copy a file to the .horuse folder when it is not in the project path? Another scenario would be how do we handle symlinks from files that don't exist on the user's machine? With that in mind, this commit changes the behavior of the `Copy` function to ignore symlinks by default and only copy directories and files. Since previously we were no longer analyzing sysmlinks, this change will not be noticed by the user. This commit also change the assertiveness of tests to check if all files and directories was copied correctly. Updates #718 Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup
force-pushed
the
copy-tests
branch
from
d9dfe13 to
8d28a37
Compare
iancardosozup
approved these changes
Nov 18, 2021
nathanmartinszup
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if some symlink exists on project path during the copy we was
creating a directory instead evaluating the sysmlink.
Evaluating the symlink makes us need to deal with several scenarios,
such as, how should we copy a file to the .horuse folder when it is not
in the project path? Another scenario would be how do we handle symlinks
from files that don't exist on the user's machine?
With that in mind, this commit changes the behavior of the
Copyfunctionto ignore symlinks by default and only copy directories and files. Since
previously we were no longer analyzing sysmlinks, this change will not be
noticed by the user.
This commit also change the assertiveness of tests to check if all files
and directories was copied correctly.
Updates #718
Signed-off-by: Matheus Alcantara matheus.alcantara@zup.com.br
- What I did
- How to verify it
- Description for the changelog