formatters/trivy:fix - find correct line of dependency #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danang Heriyadi <danang.heriyadi19@gmail.com>
ne0z
requested review from
iancardosozup,
lucasbrunozup,
matheusalcantarazup,
nathanmartinszup and
wiliansilvazup
as code owners
ne0z
changed the title
matheusalcantarazup
suggested changes
Dec 17, 2021
There was a problem hiding this comment.
Thank very much for your contribution @ne0z
Can you also please change your PR and commit title to follow our patterns?
formatters/trivy:fix - find correct line of dependency
ne0z
changed the title
Signed-off-by: Danang Heriyadi <danang.heriyadi19@gmail.com>
matheusalcantarazup
suggested changes
Dec 20, 2021
Signed-off-by: Danang Heriyadi <danang.heriyadi19@gmail.com>
nathanmartinszup
approved these changes
Dec 21, 2021
matheusalcantarazup
approved these changes
Dec 21, 2021
|
Thanks very much for your contribution @ne0z |
nathanmartinszup
added a commit
that referenced
this pull request
Jan 18, 2022
Since the pull request #882 some changes were made in the line and code of the trivy formatter, and this data influences directly the hash generation. This pr will avoid this hash change by using the same data as before, but for the users the data will be showed with the fixes made in the pull request 882, leading to no braking changes and keeping the fixes. Signed-off-by: Nathan Martins <nathan.martins@zup.com.br>
nathanmartinszup
added a commit
that referenced
this pull request
Jan 18, 2022
Since the pull request #882 some changes were made in the line and code of the trivy formatter, and this data influences directly the hash generation. This pr will avoid this hash change by using the same data as before, but for the users the data will be showed with the fixes made in the pull request 882, leading to no braking changes and keeping the fixes. Signed-off-by: Nathan Martins <nathan.martins@zup.com.br>
nathanmartinszup
added a commit
that referenced
this pull request
Jan 18, 2022
Since the pull request #882 some changes were made in the line and code of the trivy formatter, and this data influences directly the hash generation. This pr will avoid this hash change by using the same data as before, but for the users the data will be showed with the fixes made in the pull request 882, leading to no braking changes and keeping the fixes. Signed-off-by: Nathan Martins <nathan.martins@zup.com.br>
nathanmartinszup
added a commit
that referenced
this pull request
Jan 20, 2022
…929) Since the pull request #882 some changes were made in the line and code of the trivy formatter, and this data influences directly the hash generation. This pr will avoid this hash change by using the same data as before, but for the users the data will be showed with the fixes made in the pull request 882, leading to no braking changes and keeping the fixes. Signed-off-by: Nathan Martins <nathan.martins@zup.com.br>
matheusalcantarazup
pushed a commit
that referenced
this pull request
Jan 21, 2022
…929) Since the pull request #882 some changes were made in the line and code of the trivy formatter, and this data influences directly the hash generation. This pr will avoid this hash change by using the same data as before, but for the users the data will be showed with the fixes made in the pull request 882, leading to no braking changes and keeping the fixes. Signed-off-by: Nathan Martins <nathan.martins@zup.com.br> (cherry picked from commit 0a2ecee)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danang Heriyadi danang.heriyadi19@gmail.com
- What I did
Tried to solve #881 bug by adding some code to find where the correct line. I am not sure it's effective or not. But it's work. In my code, I define the start line from 0, is that correct?
- How to verify it
Check Horusec report on the go.sum file it will show as below:
- Description for the changelog