analyzer:chore - split analyzer implementation into runner #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
matheusalcantarazup
force-pushed
the
analyzer-runner
branch
2 times, most recently
from
52485fb to
b71b386
Compare
nathanmartinszup
approved these changes
Jan 3, 2022
Previously the Analyzer struct holds the entire pipeline of an analysis, which add a lot of complexity, since this pipeline has a lot of steps: Detect languages, orchestrate tools by languages, send analysis to Horusec manager and them print the results on stdout. This commit split the Analyzer struct into a new struct `runner`. This new struct will be responsible only to orchestrate all tools to their respective languages. The coded implemented on runner is basically a copy and paste from Analyzer implementation, so the behavior remains the same. Some documentation was also added to try do make more clear what are the steps that Analyzer do, and what a runner means. Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup
force-pushed
the
analyzer-runner
branch
from
b71b386 to
2b54638
Compare
iancardosozup
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Analyzer struct holds the entire pipeline of an analysis,
which add a lot of complexity, since this pipeline has a lot of steps:
Detect languages, orchestrate tools by languages, send analysis to Horusec
manager and them print the results on stdout.
This commit split the Analyzer struct into a new struct
runner.This new struct will be responsible only to orchestrate all tools to
their respective languages. The coded implemented on runner is basically
a copy and paste from Analyzer implementation, so the behavior remains
the same.
Some documentation was also added to try do make more clear what are the
steps that Analyzer do, and what a runner means.
Signed-off-by: Matheus Alcantara matheus.alcantara@zup.com.br
- What I did
- How to verify it
- Description for the changelog