yarnaudit:chore - improve tests and code cleaning #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit add some new asserts on successful parsing yarn results to verify that all fields of Vulnerability was filled. Note that the test cases from `TestParseOutputNpm`(yes, it was misspelled) was moved to `TestYarnAuditParseOutput` to centralize all tests as it is done in the other tests of the other formatters. Some code organization was also made, and the entities packages was removed and the yarn schema output was moved to yarnaudit package. Updates #718 Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
nathanmartinszup
approved these changes
Jan 3, 2022
iancardosozup
approved these changes
Jan 3, 2022
nathanmartinszup
pushed a commit
that referenced
this pull request
Feb 10, 2022
This commit add some new asserts on successful parsing yarn results to verify that all fields of Vulnerability was filled. Note that the test cases from `TestParseOutputNpm`(yes, it was misspelled) was moved to `TestYarnAuditParseOutput` to centralize all tests as it is done in the other tests of the other formatters. Some code organization was also made, and the entities packages was removed and the yarn schema output was moved to yarnaudit package. Updates #718 Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br> (cherry picked from commit f2c500d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add some new asserts on successful parsing yarn results
to verify that all fields of Vulnerability was filled.
Note that the test cases from
TestParseOutputNpm(yes, it wasmisspelled) was moved to
TestYarnAuditParseOutputto centralizeall tests as it is done in the other tests of the other formatters.
Some code organization was also made, and the entities packages was
removed and the yarn schema output was moved to yarnaudit package.
Updates #718
Signed-off-by: Matheus Alcantara matheus.alcantara@zup.com.br
- What I did
- How to verify it
- Description for the changelog