swift:chore - Improvements Tests of all Swift Rules #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiliansilvazup
requested review from
iancardosozup,
lucasbrunozup,
matheusalcantarazup and
nathanmartinszup
as code owners
matheusalcantarazup
suggested changes
Jan 27, 2022
wiliansilvazup
force-pushed
the
chore/swift-rules-tests
branch
2 times, most recently
from
2add364 to
3780ebf
Compare
matheusalcantarazup
approved these changes
Jan 28, 2022
nathanmartinszup
approved these changes
Jan 28, 2022
wiliansilvazup
force-pushed
the
chore/swift-rules-tests
branch
from
3780ebf to
190b4da
Compare
wiliansilvazup
requested review from
matheusalcantarazup and
nathanmartinszup
wiliansilvazup
force-pushed
the
chore/swift-rules-tests
branch
4 times, most recently
from
19cb566 to
c5dc712
Compare
nathanmartinszup
approved these changes
Feb 3, 2022
iancardosozup
suggested changes
Feb 8, 2022
Add improvements for swift rules with scenarios vulnerables and safe codes in yours tests. Follow the issue #630 for more details. Notes: > Why before swift tool using horusec-engine found 16 vulnerabilities and now found only 1? * Abouts rule HS-SWIFT-14, Before in examples folder this rule is found 11 times and now is showed only 3 times, because I changed to only get the specific code `loadHTMLString` avoiding repetition of vulnerabilities. * About rule HS-SWIFT-20, Before in examples folder this rule is found 5 times and now is showed only 1 time, because I changed to only get the specific code `UIWebView\(\)` other thing before it was just UIWebView and it can generate a lot of false positives and now it does not. Signed-off-by: wilian <wilian.silva@zup.com.br> Signed-off-by: Wilian Gabriel <wilian.silva@zup.com.br>
wiliansilvazup
force-pushed
the
chore/swift-rules-tests
branch
from
c5dc712 to
c15ec96
Compare
done |
iancardosozup
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add improvements for swift rules with scenarios vulnerables and safe codes in yours tests.
Follow the issue #630 for more details.
Notes:
loadHTMLStringavoiding repetition of vulnerabilities.UIWebView\(\)other thing before it was just UIWebView and it can generate a lot of false positives and now it does not.Signed-off-by: wilian wilian.silva@zup.com.br