Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow:feat - Automating the release notes #997

Merged
merged 1 commit into from
Mar 8, 2022
Merged

workflow:feat - Automating the release notes #997

merged 1 commit into from
Mar 8, 2022

Conversation

wiliansilvazup
Copy link
Contributor

In this PR I'll update Release Beta, RC and Final to set automatic
body in release notes. I changed file release-new.yml to
release-final.yml and I changed file alpha.yml to release-alpha.yml

Signed-off-by: Wilian Gabriel wilian.silva@zup.com.br

@wiliansilvazup wiliansilvazup marked this pull request as draft February 19, 2022 00:33
@wiliansilvazup
Copy link
Contributor Author

wiliansilvazup commented Feb 19, 2022 •
edited
Loading

Note that I created a validation so that only specific users are allowed to run workflows as shown in the image below:
image

I tried to add the author also according to the gorelease documentation just use github in the changelog instead of git but I was getting this 404 error and I didn't know what else to do.

@wiliansilvazup wiliansilvazup marked this pull request as ready for review February 21, 2022 11:45
@wiliansilvazup wiliansilvazup force-pushed the main branch 4 times, most recently from 5de57c0 to e85d19d Compare February 21, 2022 18:16
@wiliansilvazup
Copy link
Contributor Author

This PR Depend of the ZupIT/horusec-devkit#166

@wiliansilvazup wiliansilvazup force-pushed the main branch 2 times, most recently from fb0d355 to d09cfa9 Compare February 21, 2022 21:39
@wiliansilvazup
Copy link
Contributor Author

I created a validation to check if pipeline failed and remove tag created on github: https://github.com/wiliansilvazup/horusec/runs/5280186446?check_suite_focus=true

And now is possible see the users on Release Notes 🥳

@matheusalcantarazup
Copy link
Contributor

Wouldn't be better change the commit message to workflow:feat - Automating the release notes?

@wiliansilvazup
Copy link
Contributor Author

Wouldn't be better change the commit message to workflow:feat - Automating the release notes?

yeah, I'll adjust this.

@wiliansilvazup wiliansilvazup changed the title workflow:feat - Automating the release body workflow:feat - Automating the release notes Feb 22, 2022
nathanmartinszup
nathanmartinszup reviewed Feb 23, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@wiliansilvazup wiliansilvazup self-assigned this Feb 24, 2022
@wiliansilvazup wiliansilvazup force-pushed the main branch 3 times, most recently from e52e93f to 952c21f Compare February 24, 2022 12:19
@wiliansilvazup
Copy link
Contributor Author

Wait the PR #996 to fix problems on sintax

@wiliansilvazup wiliansilvazup added the kind/enhancement This issue is related to a new feature or request label Feb 25, 2022
@wiliansilvazup
Copy link
Contributor Author

Wait the PR #996 to fix problems on sintax

done

@matheusalcantarazup
Copy link
Contributor

@wiliansilvazup resolve the conflicts please

@wiliansilvazup
workflow:feat - Automating the release notes
be666cf 
In this PR I'll update Release Beta, RC and Final to set automatic
body in release notes. I changed file release-new.yml to
release-final.yml and I changed file alpha.yml to release-alpha.yml

Signed-off-by: Wilian Gabriel <wilian.silva@zup.com.br>
@nathanmartinszup nathanmartinszup merged commit 578e883 into ZupIT:main Mar 8, 2022
nathanmartinszup pushed a commit that referenced this pull request Apr 4, 2022
@wiliansilvazup @nathanmartinszup
workflow:feat - Automating the release notes (#997)
6efd1ca 
In this PR I'll update Release Beta, RC and Final to set automatic
body in release notes. I changed file release-new.yml to
release-final.yml and I changed file alpha.yml to release-alpha.yml

Signed-off-by: Wilian Gabriel <wilian.silva@zup.com.br>
(cherry picked from commit 578e883)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanmartinszup nathanmartinszup nathanmartinszup approved these changes

@matheusalcantarazup matheusalcantarazup Awaiting requested review from matheusalcantarazup

@lucasbrunozup lucasbrunozup Awaiting requested review from lucasbrunozup

@iancardosozup iancardosozup Awaiting requested review from iancardosozup

Assignees

@wiliansilvazup wiliansilvazup

Labels
kind/enhancement This issue is related to a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wiliansilvazup @matheusalcantarazup @nathanmartinszup