Extracts sort from the list of providers for method list

Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>

pkg/cmd/add_repo.go

@@ -20,7 +20,6 @@ import (
 	"errors"
 	"fmt"
 	"reflect"
-	"sort"
 	"strings"
 
 	"github.com/spf13/cobra"
@@ -288,7 +287,6 @@ func (ar *addRepoCmd) resolveFlags(cmd *cobra.Command) (formula.Repo, error) {
 		}
 	}
 	if !providerValid {
-		sort.Strings(providers)
 		return formula.Repo{}, errors.New("please select a provider from " + strings.Join(providers, ", "))
 	}
 

pkg/cmd/add_repo_test.go

@@ -18,7 +18,6 @@ package cmd
 
 import (
 	"errors"
-	"sort"
 	"strings"
 	"testing"
 
@@ -46,9 +45,6 @@ func TestAddRepoCmd(t *testing.T) {
 	repoProviders.Add("GitLab", formula.Git{Repos: gitRepositoryWithoutTagsMock, NewRepoInfo: github.NewRepoInfo})
 	repoProviders.Add("Bitbucket", formula.Git{Repos: gitRepositoryErrorsMock, NewRepoInfo: github.NewRepoInfo})
 
-	repoProvidersSorted := repoProviders.List()
-	sort.Strings(repoProvidersSorted)
-
 	repoTest := &formula.Repo{
 		Provider: "Github",
 		Name:     "someRepo1",
@@ -251,7 +247,7 @@ func TestAddRepoCmd(t *testing.T) {
 			name:   "fail flags with wrong provider",
 			args:   []string{"--provider=github"},
 			fields: fields{},
-			want:   errors.New("please select a provider from " + strings.Join(repoProvidersSorted, ", ")),
+			want:   errors.New("please select a provider from " + strings.Join(repoProviders.List(), ", ")),
 		},
 		{
 			name:   "fail flags with empty name",

pkg/formula/repo.go

@@ -16,7 +16,11 @@
 
 package formula
 
-import "github.com/ZupIT/ritchie-cli/pkg/git"
+import (
+	"sort"
+
+	"github.com/ZupIT/ritchie-cli/pkg/git"
+)
 
 const RepoCommonsName = RepoName("commons")
 
@@ -88,6 +92,8 @@ func (re RepoProviders) List() []string {
 		providers = append(providers, provider.String())
 	}
 
+	sort.Strings(providers)
+
 	return providers
 }