Review corrections

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>

pkg/cmd/delete_credential.go

@@ -77,8 +77,6 @@ func (d deleteCredentialCmd) runFormula() CommandRunnerFunc {
 		inputParams, err := d.resolveInput(cmd, curEnv)
 		if err != nil {
 			return err
-		} else if inputParams.provider == "" {
-			return nil
 		}
 
 		if err := d.Delete(inputParams.provider); err != nil {
@@ -93,9 +91,8 @@ func (d deleteCredentialCmd) runFormula() CommandRunnerFunc {
 func (d *deleteCredentialCmd) resolveInput(cmd *cobra.Command, context string) (inputConfig, error) {
 	if IsFlagInput(cmd) {
 		return d.resolveFlags(cmd)
-	} else {
-		return d.resolvePrompt(context)
 	}
+	return d.resolvePrompt(context)
 }
 
 func (d *deleteCredentialCmd) resolvePrompt(context string) (inputConfig, error) {
@@ -130,6 +127,8 @@ func (d *deleteCredentialCmd) resolveFlags(cmd *cobra.Command) (inputConfig, err
 	provider, err := cmd.Flags().GetString(providerFlagName)
 	if err != nil {
 		return inputConfig{}, err
+	} else if provider == "" {
+		return inputConfig{}, errors.New("please provide a value for 'provider'")
 	}
 	return inputConfig{provider}, nil
 }

pkg/cmd/delete_credential_test.go

@@ -295,7 +295,7 @@ func TestDeleteCredential(t *testing.T) {
 	}
 }
 
-func TestDeleteCredentialViaPrompt(t *testing.T) {
+func TestDeleteCredentialFormula(t *testing.T) {
 	homeDir := os.TempDir()
 	ritHomeDir := filepath.Join(homeDir, ".rit")
 	credentialPath := filepath.Join(ritHomeDir, "credentials", env.Default)
@@ -326,6 +326,11 @@ func TestDeleteCredentialViaPrompt(t *testing.T) {
 			name: "execute flag with success",
 			args: "--provider=github",
 		},
+		{
+			name:    "execute flag with empty provider fail",
+			args:    "--provider=",
+			wantErr: "please provide a value for 'provider'",
+		},
 		{
 			name:            "fail on input list error",
 			wantErr:         "some error",