Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

The fix for issue #914 needs to be improved so that we don't unnecessarily break compatibility with Docker Desktop <2.5.0 and also that we support running inside WSL* on Windows #987

Closed
danilomarqueszup opened this issue Jul 1, 2021 · 0 comments · Fixed by #989
Labels
🐳 Docker Related to Docker 🔨 improvement Improvement in features usability Related to tool usability

Comments

@danilomarqueszup
Copy link
Contributor

The fix for issue #914 needs to be improved so that we don't unnecessarily break compatibility with Docker Desktop <2.5.0 and also that we support running inside WSL on Windows

What happened:

Using the latest versions of Ritchie with the fix for #914, the Docker Runner is unnecessarily broken with Docker Desktop <2.5.0 or within WSL* environments

What you expected to happen:

The Docker Runner should normally run in both scenarios.

How to reproduce it (as minimally and precisely as possible):

Try running any Formula on Windows/MacOS with the Docker Runner and Docker Desktop < 2.5.0 installed. Also, on Windows, try the same thing within WSL* but with the latest Docker Desktop versions.

Anything else we need to know?:

Environment:

  • Ritchie version: 2.11.3
  • Operating System: Windows/MacOS
dcominottim added a commit to dcominottim/ritchie-cli that referenced this issue Jul 1, 2021
dcominottim added a commit to dcominottim/ritchie-cli that referenced this issue Jul 1, 2021
@GuillaumeFalourd GuillaumeFalourd added 🔨 improvement Improvement in features usability Related to tool usability 🐳 Docker Related to Docker labels Jul 1, 2021
GuillaumeFalourd pushed a commit that referenced this issue Jul 2, 2021
… on Windows/MacOS and adding compatibility to WSL* (#989)

* Fixes #914 by changing Docker's invocation command from 'docker' to 'com.docker.cli'.

Signed-off-by: Danilo Cominotti Marques <dcominottim@gmail.com>

* Fixes #914 by changing Docker's invocation command from 'docker' to 'com.docker.cli'.

Signed-off-by: Danilo Cominotti Marques <dcominottim@gmail.com>

* Fixes #987

* Improves fix for #987
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐳 Docker Related to Docker 🔨 improvement Improvement in features usability Related to tool usability
Projects
None yet
2 participants