Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Create uninstall command #1052

Conversation

victor-schumacher
Copy link
Contributor

@victor-schumacher victor-schumacher commented Oct 7, 2021

WIP 🚧

Description

Closes #1032

How to verify it

Changelog


This pull request generated the following artifacts.

To test the health and quality of this implementation, download the respective binary for your operating system, unzip and directly run the binary like the examples below.

  • Windows
    Download the file: rit-windows.zip
    Unzip to some folder like: C:\home\user\downloads\pr1052
    Access the folder: cd C:\home\user\downloads\pr1052
    Directly call the binary: .\rit.exe --version or .\rit.exe name of formula

  • Linux
    Download the file: rit-linux.zip
    Unzip to some folder like: /home/user/downloads/pr1052
    Access the folder: cd /home/user/downloads/pr1052
    Assign execute permission to binary: chmod +x ./rit
    Directly call the binary: ./rit --version or ./rit name of formula

  • MacOS
    Download the file: rit-macos.zip
    Unzip to some folder like: /home/user/downloads/pr1052
    Access the folder: cd /home/user/downloads/pr1052
    Assign execute permission to binary: chmod +x ./rit
    Directly call the binary: ./rit --version or ./rit name of formula

Generated at Thu Oct 07 2021 02:25:27 GMT+0000 (Coordinated Universal Time)


This pull request generated the following artifacts.

To test the health and quality of this implementation, download the respective binary for your operating system, unzip and directly run the binary like the examples below.

  • Windows
    Download the file: rit-windows.zip
    Unzip to some folder like: C:\home\user\downloads\pr1052
    Access the folder: cd C:\home\user\downloads\pr1052
    Directly call the binary: .\rit.exe --version or .\rit.exe name of formula

  • Linux
    Download the file: rit-linux.zip
    Unzip to some folder like: /home/user/downloads/pr1052
    Access the folder: cd /home/user/downloads/pr1052
    Assign execute permission to binary: chmod +x ./rit
    Directly call the binary: ./rit --version or ./rit name of formula

  • MacOS
    Download the file: rit-macos.zip
    Unzip to some folder like: /home/user/downloads/pr1052
    Access the folder: cd /home/user/downloads/pr1052
    Assign execute permission to binary: chmod +x ./rit
    Directly call the binary: ./rit --version or ./rit name of formula

Generated at Wed Oct 27 2021 11:09:06 GMT+0000 (Coordinated Universal Time)

@victor-schumacher victor-schumacher changed the title first steps Create uninstall command Oct 7, 2021
Signed-off-by: Victor <victorschumacher255@gmail.com>
@victor-schumacher victor-schumacher force-pushed the 1033/feature/createUninstallCMD branch from 24e9992 to 0628aeb Compare October 7, 2021 02:23
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2021

Codecov Report

Merging #1052 (f4e937c) into main (5580033) will decrease coverage by 0.64%.
The diff coverage is 4.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1052      +/-   ##
==========================================
- Coverage   84.10%   83.45%   -0.65%     
==========================================
  Files         123      124       +1     
  Lines        4982     5023      +41     
==========================================
+ Hits         4190     4192       +2     
- Misses        518      557      +39     
  Partials      274      274              
Flag Coverage Δ
unittests 83.45% <4.87%> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cmd/uninstall.go 0.00% <0.00%> (ø)
pkg/commands/builder.go 91.12% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5580033...f4e937c. Read the comment docs.

Signed-off-by: Victor <victorschumacher255@gmail.com>
@victor-schumacher victor-schumacher force-pushed the 1033/feature/createUninstallCMD branch from dad8215 to bf1635f Compare October 8, 2021 01:53
Signed-off-by: Victor <victorschumacher255@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kelsoncarmozinezup
Copy link

Thaks @victor-schumacher for your contribuition.

Does the status remain WIP?

Could you fix the error in lint?

@victor-schumacher
Copy link
Contributor Author

victor-schumacher commented Oct 27, 2021

Thaks @victor-schumacher for your contribuition.

Does the status remain WIP?

Could you fix the error in lint?

Hi @kelsoncarmozinezup
Stills WIP, but i'm very busy at the moment. Feel free to assignee to someone else.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an rit uninstall core command
3 participants