This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
[FIX] env runner formula #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeFalourd
approved these changes
Jun 2, 2020
victor-schumacher
approved these changes
Jun 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
- Coverage 43.83% 43.81% -0.02%
==========================================
Files 59 59
Lines 2407 2408 +1
==========================================
Hits 1055 1055
- Misses 1166 1167 +1
Partials 186 186
Continue to review full report at Codecov.
|
|
/merge qa |
|
🔥 Merge Conflict |
|
/merge qa |
|
👌 Merged branch fix/env-runner-formula into qa |
sandokandias
approved these changes
Jun 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added cmd.Env = os.Environ() in runner.go
- How I did it
Added cmd.Env = os.Environ() in runner.go
- How to verify it
Tests with enerlioJr and Guillaume
- Description for the changelog
Pass env when running formula