Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[FEATURE] Login prompt #154

Merged
merged 12 commits into from
Jun 15, 2020
Merged

Conversation

marcosgmgm
Copy link
Contributor

- What I did
Was altered login to use prompt

- How I did it
Change pkg security and alter cmd login

- How to verify it
Unit tests and manual tests

- Description for the changelog

Login prompt

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2020

Codecov Report

Merging #154 into master will increase coverage by 0.78%.
The diff coverage is 55.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   57.54%   58.33%   +0.78%     
==========================================
  Files          65       65              
  Lines        2511     2501      -10     
==========================================
+ Hits         1445     1459      +14     
+ Misses        819      793      -26     
- Partials      247      249       +2     
Impacted Files Coverage Δ
pkg/formula/default_repo.go 0.00% <0.00%> (ø)
pkg/formula/loader_team.go 0.00% <0.00%> (ø)
pkg/cmd/init.go 31.37% <8.33%> (-3.42%) ⬇️
pkg/cmd/login.go 51.21% <48.48%> (-22.12%) ⬇️
pkg/security/secteam/login.go 79.59% <69.69%> (ø)
pkg/credential/credteam/finder.go 66.66% <100.00%> (ø)
pkg/credential/credteam/setter.go 65.00% <100.00%> (ø)
pkg/credential/credteam/settings.go 65.00% <100.00%> (ø)
pkg/formula/default_setup.go 67.12% <100.00%> (ø)
pkg/security/secteam/logout.go 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f12807...2dac3e9. Read the comment docs.

@marcosgmgm
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jun 10, 2020

👌 Merged branch feature/login-prompt into qa

@marcosgmgm
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jun 10, 2020

👌 Merged branch feature/login-prompt into qa

@marcosgmgm
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jun 10, 2020

👌 Merged branch feature/login-prompt into qa

@marcosgmgm marcosgmgm merged commit cbbfdaf into ZupIT:master Jun 15, 2020
@marcosgmgm marcosgmgm deleted the feature/login-prompt branch June 15, 2020 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants