Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[FEATURE] Build formula with Ritchie-cli #180

Merged
merged 28 commits into from
Jun 23, 2020
Merged

[FEATURE] Build formula with Ritchie-cli #180

merged 28 commits into from
Jun 23, 2020

Conversation

kaduartur
Copy link
Contributor

- What I did
I created a new command rit build formulas to build formulas locally.
rit-build-formula

- How to verify it

  • Run the command rit build formulas to build formulas, you can run the command with the --watch flag rit build formulas --watch and get real-time updates.
  • Run tests with the command make unit-test

- Description for the changelog
Created the build.go and watcher.go to build and watch your formulas locally.

@kaduartur kaduartur added the ✨ feature Suggest a new feature or enhancement to the Ritchie project label Jun 18, 2020
@kaduartur kaduartur self-assigned this Jun 18, 2020
@GuillaumeFalourd GuillaumeFalourd linked an issue Jun 18, 2020 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2020

Codecov Report

Merging #180 into master will increase coverage by 0.05%.
The diff coverage is 50.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   58.10%   58.16%   +0.05%     
==========================================
  Files          75       75              
  Lines        2843     2842       -1     
==========================================
+ Hits         1652     1653       +1     
+ Misses        930      929       -1     
+ Partials      261      260       -1     
Impacted Files Coverage Δ
pkg/cmd/build.go 0.00% <0.00%> (ø)
pkg/cmd/build_formula.go 0.00% <0.00%> (ø)
pkg/cmd/formulas.go 94.20% <ø> (ø)
pkg/formula/formula.go 79.16% <ø> (ø)
pkg/formula/watcher/watcher.go 76.47% <76.47%> (+7.02%) ⬆️
pkg/formula/builder/build.go 81.53% <81.53%> (ø)
pkg/formula/workspace/workspace_manager.go 95.12% <95.12%> (ø)
pkg/slice/sliceutil/slice_util.go 100.00% <100.00%> (ø)
pkg/formula/build/build.go
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca80333...2bdb7e3. Read the comment docs.

@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jun 22, 2020

👌 Merged branch feature/build_formula into qa

@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jun 22, 2020

👌 Merged branch feature/build_formula into qa

@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jun 22, 2020

👌 Merged branch feature/build_formula into qa

@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jun 22, 2020

👌 Merged branch feature/build_formula into qa

cmd/single/main.go Outdated Show resolved Hide resolved
cmd/single/main.go Outdated Show resolved Hide resolved
cmd/team/main.go Outdated Show resolved Hide resolved
cmd/team/main.go Outdated Show resolved Hide resolved
pkg/formula/build/build.go Outdated Show resolved Hide resolved
pkg/formula/build/build_test.go Outdated Show resolved Hide resolved
pkg/formula/build/build.go Outdated Show resolved Hide resolved
@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jun 22, 2020

👌 Merged branch feature/build_formula into qa

@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jun 22, 2020

👌 Merged branch feature/build_formula into qa

@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jun 22, 2020

👌 Merged branch feature/build_formula into qa

@kaduartur
Copy link
Contributor Author

@sandokandias
Copy link
Contributor

very good!

@kaduartur kaduartur merged commit 196f8d6 into ZupIT:master Jun 23, 2020
@kaduartur kaduartur deleted the feature/build_formula branch June 23, 2020 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] rit build formula command
4 participants