Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[FEATURE] Create formula and build #212

Merged
merged 21 commits into from
Jun 30, 2020
Merged

[FEATURE] Create formula and build #212

merged 21 commits into from
Jun 30, 2020

Conversation

kaduartur
Copy link
Contributor

- What I did

  • Add the new template for build formula inside Windows named build.bat
  • Create packages inside the formula package to organize it
  • Add omitempty to Command and Formula struct
  • Add validation when RepoUrl does not exist in tree.json

- How to verify it
Run tests and run the command rit create formula to check it

@kaduartur kaduartur added the ✨ feature Suggest a new feature or enhancement to the Ritchie project label Jun 25, 2020
@kaduartur kaduartur self-assigned this Jun 25, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2020

Codecov Report

Merging #212 into master will increase coverage by 1.48%.
The diff coverage is 73.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   64.55%   66.03%   +1.48%     
==========================================
  Files          86       72      -14     
  Lines        4319     2706    -1613     
==========================================
- Hits         2788     1787    -1001     
+ Misses       1144      662     -482     
+ Partials      387      257     -130     
Impacted Files Coverage Δ
pkg/cmd/add_repo.go 50.00% <ø> (-3.25%) ⬇️
pkg/cmd/build_formula.go 0.00% <0.00%> (ø)
pkg/formula/create_builder.go 0.00% <0.00%> (ø)
pkg/formula/runner/docker_pre_runner.go 55.55% <33.33%> (ø)
pkg/formula/builder/build.go 77.02% <58.33%> (-7.67%) ⬇️
pkg/cmd/create_formula.go 54.83% <58.94%> (-3.72%) ⬇️
pkg/formula/runner/post_run.go 46.15% <60.00%> (ø)
pkg/formula/formula.go 66.66% <63.63%> (-17.30%) ⬇️
pkg/formula/creator/lang.go 69.86% <69.86%> (ø)
pkg/formula/runner/default_setup.go 65.33% <70.37%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88a8591...cb53c2a. Read the comment docs.

@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jun 26, 2020

👌 Merged branch feature/create_and_build_formula into qa

@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jun 29, 2020

👌 Merged branch feature/create_and_build_formula into qa

@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jun 29, 2020

👌 Merged branch feature/create_and_build_formula into qa

pkg/formula/repo.go Outdated Show resolved Hide resolved
@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jun 30, 2020

👌 Merged branch feature/create_and_build_formula into qa

@kaduartur kaduartur merged commit bb3034a into ZupIT:master Jun 30, 2020
@kaduartur kaduartur deleted the feature/create_and_build_formula branch June 30, 2020 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
None yet
3 participants