Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[FEATURE] Adding hello world template in PHP (Issue #185) #216

Merged
merged 8 commits into from
Jun 29, 2020

Conversation

antonioolf
Copy link

- What I did

- How I did it

  • I used as example the other existing templates and created an equivalent for PHP language, making the necessary adaptations.

- How to verify it

- Run "rit create formula"
- Enter the new formula command
- Choose PHP in the languages list
- go to the local repository folder
- run "make test-local"
- run the new created command

- Description for the changelog

  • Added support for PHP language

Copy link
Contributor

@victor-schumacher victor-schumacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonioolf
Copy link
Author

Making some adjusts

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2020

Codecov Report

Merging #216 into master will increase coverage by 0.03%.
The diff coverage is 65.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   60.24%   60.28%   +0.03%     
==========================================
  Files          75       75              
  Lines        2895     2923      +28     
==========================================
+ Hits         1744     1762      +18     
- Misses        898      903       +5     
- Partials      253      258       +5     
Impacted Files Coverage Δ
pkg/formula/creator.go 78.91% <50.00%> (-0.40%) ⬇️
pkg/formula/lang.go 67.14% <66.66%> (-0.10%) ⬇️
pkg/cmd/create_formula.go 54.38% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ff42d...66fc0e3. Read the comment docs.

@victorschumacherzup victorschumacherzup added the ✨ feature Suggest a new feature or enhancement to the Ritchie project label Jun 29, 2020
@victorschumacherzup victorschumacherzup merged commit 88a8591 into ZupIT:master Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Adding hello world template in PHP (rit create formula)
5 participants