Skip to content
This repository was archived by the owner on Jul 12, 2022. It is now read-only.

[FEATURE] Build formulas on Windows #232

Merged
merged 8 commits into from
Jul 7, 2020
Merged

[FEATURE] Build formulas on Windows #232

merged 8 commits into from
Jul 7, 2020

Conversation

kaduartur
Copy link
Contributor

- What I did

I create scripts to build formulas on Windows in the following languages:

  • Java
  • Node
  • Php
  • Python

- How I did it

I created templates to build.bat file, inside the pkg/formula/creator/templates for all supported languages.

- How to verify it
On Windows, run the command rit create formula. You can run the rit build formula command to get the same result too.
After that, you can run your formula on windows

- Description for the changelog
Create scripts to build formulas on Windows

@kaduartur kaduartur added ✨ feature Suggest a new feature or enhancement to the Ritchie project 💠 Windows This issue or pull request is specific to the Windows operating system labels Jul 1, 2020
@kaduartur kaduartur self-assigned this Jul 1, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2020

Codecov Report

Merging #232 into master will decrease coverage by 1.88%.
The diff coverage is 82.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage   67.93%   66.05%   -1.89%     
==========================================
  Files          73       72       -1     
  Lines        3000     2598     -402     
==========================================
- Hits         2038     1716     -322     
+ Misses        686      646      -40     
+ Partials      276      236      -40     
Impacted Files Coverage Δ
pkg/formula/builder/build.go 77.02% <ø> (-0.98%) ⬇️
pkg/formula/creator/creator.go 81.27% <78.57%> (-2.71%) ⬇️
pkg/cmd/create_formula.go 57.60% <100.00%> (-4.31%) ⬇️
pkg/cmd/set_credential.go 50.79% <0.00%> (-15.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52c6f0...b2b5302. Read the comment docs.

@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jul 3, 2020

🔥 Merge Conflict

@kaduartur kaduartur merged commit 40a3c28 into ZupIT:master Jul 7, 2020
@kaduartur kaduartur deleted the feature/build_formula_windows branch July 7, 2020 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ feature Suggest a new feature or enhancement to the Ritchie project 💠 Windows This issue or pull request is specific to the Windows operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants