Skip to content
This repository was archived by the owner on Jul 12, 2022. It is now read-only.

[FEATURE] Change Login and Init behavior #236

Merged
merged 6 commits into from
Jul 2, 2020
Merged

[FEATURE] Change Login and Init behavior #236

merged 6 commits into from
Jul 2, 2020

Conversation

marcoscostazup
Copy link
Contributor

- What I did

  • Removed OTP flag from server.json so that init and login has to request it from server now

- How to verify it

  • Open server.json (after run init again)

- Description for the changelog

  • Removed OTP flag from server.json so that init and login has to request it from server now

* OTP flag isn't saved on server.json anymore
* OTP flag is requested on login instead of been searched on server.json
@codecov-commenter
Copy link

Codecov Report

Merging #236 into master will decrease coverage by 0.08%.
The diff coverage is 75.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   66.13%   66.04%   -0.09%     
==========================================
  Files          72       73       +1     
  Lines        2737     2754      +17     
==========================================
+ Hits         1810     1819       +9     
- Misses        669      674       +5     
- Partials      258      261       +3     
Impacted Files Coverage Δ
pkg/cmd/init.go 75.67% <66.66%> (-1.18%) ⬇️
pkg/cmd/login.go 74.54% <66.66%> (-1.93%) ⬇️
pkg/security/otp/otp.go 76.47% <76.47%> (ø)
pkg/server/setter.go 71.42% <100.00%> (ø)
pkg/formula/watcher/watcher.go 70.58% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0bc950...b53d962. Read the comment docs.

@marcoscostazup marcoscostazup added the ✨ feature Suggest a new feature or enhancement to the Ritchie project label Jul 2, 2020
Copy link
Contributor

@viniciussousazup viniciussousazup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🥇

@marcoscostazup marcoscostazup merged commit a01d7cc into ZupIT:master Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants