Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

List credentials command #295

Merged
merged 34 commits into from
Jul 28, 2020
Merged

List credentials command #295

merged 34 commits into from
Jul 28, 2020

Conversation

victor-schumacher
Copy link
Contributor

@victor-schumacher victor-schumacher commented Jul 17, 2020 •
edited
Loading

- What I did
Added list credential command

image

The value of credentials will have 66% of them hidden;
In cases of long values, 12 characters will be shown with the suffix "..."

- How to verify it

rit list credential

- Description for the changelog
List credential command added

@victor-schumacher victor-schumacher changed the title Feature/list credentials List credentials command Jul 17, 2020
@victor-schumacher victor-schumacher self-assigned this Jul 17, 2020
@victor-schumacher victor-schumacher added 2.0.0 ✨ feature Suggest a new feature or enhancement to the Ritchie project 🚧 WIP Work in Progress labels Jul 17, 2020
@victor-schumacher victor-schumacher linked an issue Jul 17, 2020 that may be closed by this pull request
[FEATURE] rit list credential command #178
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (ritchie-2.0.0@dc33799). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             ritchie-2.0.0     #295   +/-   ##
================================================
  Coverage                 ?   63.17%           
================================================
  Files                    ?       78           
  Lines                    ?     2520           
  Branches                 ?        0           
================================================
  Hits                     ?     1592           
  Misses                   ?      767           
  Partials                 ?      161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc33799...96b8550. Read the comment docs.

@victor-schumacher victor-schumacher marked this pull request as ready for review July 24, 2020 12:44
brunats
brunats reviewed Jul 24, 2020
View reviewed changes
pkg/credential/setter.go Outdated Show resolved Hide resolved
brunats
brunats reviewed Jul 24, 2020
View reviewed changes
pkg/credential/settings.go Outdated Show resolved Hide resolved
brunats
brunats approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@brunats brunats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, congrats 👏

kaduartur
kaduartur suggested changes Jul 24, 2020
View reviewed changes
pkg/cmd/list_credential.go Outdated Show resolved Hide resolved
pkg/cmd/set_credential.go Outdated Show resolved Hide resolved
pkg/cmd/set_credential_test.go Outdated Show resolved Hide resolved
pkg/rcontext/context.go Outdated Show resolved Hide resolved
pkg/rcontext/finder.go Outdated Show resolved Hide resolved
pkg/credential/settings.go Outdated Show resolved Hide resolved
pkg/credential/settings.go Outdated Show resolved Hide resolved
pkg/credential/settings.go Outdated Show resolved Hide resolved
pkg/credential/settings.go Outdated Show resolved Hide resolved
pkg/credential/settings.go Outdated Show resolved Hide resolved
@brunasilvazup brunasilvazup self-requested a review July 27, 2020 14:38
sandokandias
sandokandias suggested changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@sandokandias sandokandias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

An example to consider to print the credentials table

@victor-schumacher victor-schumacher merged commit 953bbe2 into ZupIT:ritchie-2.0.0 Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaduartur kaduartur kaduartur requested changes

@brunats brunats brunats approved these changes

@sandokandias sandokandias sandokandias approved these changes

@viniciussousazup viniciussousazup Awaiting requested review from viniciussousazup

@marcosgmgm marcosgmgm Awaiting requested review from marcosgmgm

@brunasilvazup brunasilvazup Awaiting requested review from brunasilvazup

Assignees

@victor-schumacher victor-schumacher

Labels
🚧 WIP Work in Progress ✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] rit list credential command
6 participants
@victor-schumacher @codecov-commenter @sandokandias @brunats @kaduartur @brunasilvazup