Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fix create formula and binaries #3

Merged
merged 3 commits into from
Apr 9, 2020
Merged

Fix create formula and binaries #3

merged 3 commits into from
Apr 9, 2020

Conversation

sandokandias
Copy link
Contributor

@sandokandias sandokandias commented Apr 9, 2020

- What I did

  • Fix formula dir in rit create formula command
  • Fix validation in rit list repo command
  • Separate binaries into different folders and main.go files
  • Update Makefile removing some unnecessary params

- How I did it

  • Add function UserHomeDir in api/api.go
  • Add function RitchieHomeDir in api/api.go
  • Create main.go for single edition in cmd/single/main.go
  • Create main.go for team edition in cmd/team/main.go
  • Remove some global vars from env/env.go
  • Pass ServerURL to structs that depends it

- How to verify it

  • Run make build-qa and checks the output
  • Run ./dist/$so/$edition/rit foreach edition and checks the commands
  • Run rit create formula and check if the ~/ritchie-formulas-local exists

- Description for the changelog

@sandokandias sandokandias changed the title Fix/create formula Fix create formula and binaries Apr 9, 2020
@marcosgmgm marcosgmgm merged commit d3bc65f into master Apr 9, 2020
@marcosgmgm marcosgmgm deleted the fix/create_formula branch April 9, 2020 11:50
viniciusaparecidozup pushed a commit that referenced this pull request Apr 29, 2020
ernelio added a commit that referenced this pull request May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants