Skip to content
This repository was archived by the owner on Jul 12, 2022. It is now read-only.

Metadata #312

Merged
Merged

Conversation

viniciussousazup
Copy link
Contributor

@viniciussousazup viniciussousazup commented Jul 24, 2020

- What I did
change create formula to generate help.json
change create formula to support modifiers
change tree resolver to use help.json

- How to verify it
set rit version to pr version:

git clone --single-branch --branch feature/metadata https://github.com/viniciussousazup/ritchie-cli /tmp/vinicius-rit-cli
cd /tmp/vinicius-rit-cli
make build
cp dist/linux/rit /usr/local/bin/ 

test rit create formula on terminal:

rit init
echo "{\"name\":\"vinicius-commons\", \"url\":\"https://github.com/viniciussousazup/ritchie-formulas\", \"version\":\"0.0.4\",\"priority\":100}" | rit add repo --stdin
rm -Rf ~/.rit/repos/commons/
mv ~/.rit/repos/vinicius-commons/ ~/.rit/repos/commons
rit create formula

- Description for the changelog

@viniciussousazup viniciussousazup self-assigned this Jul 24, 2020
@viniciussousazup viniciussousazup added 2.0.0 ✨ feature Suggest a new feature or enhancement to the Ritchie project 🚧 WIP Work in Progress labels Jul 24, 2020
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (ritchie-2.0.0@2412b33). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             ritchie-2.0.0     #312   +/-   ##
================================================
  Coverage                 ?   55.85%           
================================================
  Files                    ?       73           
  Lines                    ?     2304           
  Branches                 ?        0           
================================================
  Hits                     ?     1287           
  Misses                   ?      870           
  Partials                 ?      147           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2412b33...56ed8ba. Read the comment docs.

Copy link
Contributor

@brunasilvazup brunasilvazup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and is generating correctly, good job!

@brunasilvazup brunasilvazup changed the title Feature/metadata Metadata Jul 27, 2020
@viniciussousazup viniciussousazup merged commit 4f85808 into ZupIT:ritchie-2.0.0 Jul 27, 2020
@viniciussousazup viniciussousazup deleted the feature/metadata branch July 27, 2020 17:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants