Skip to content
This repository was archived by the owner on Jul 12, 2022. It is now read-only.

Change Set credencial #321

Merged

Conversation

viniciussousazup
Copy link
Contributor

@viniciussousazup viniciussousazup commented Jul 29, 2020

- What I did

  • added a better error msg when user not set credencial
  • change default provider to use type "secret" instead of "password"
  • change default provider names to same as master

- How to verify it

- Description for the changelog

…t provider to use type secret instead of password
@viniciussousazup viniciussousazup changed the title add a better error msg when user not set credencial and change defaul… Change Set credencial Jul 29, 2020
@viniciussousazup viniciussousazup added 2.0.0 🔨 improvement Improvement in features labels Jul 29, 2020
@viniciussousazup viniciussousazup self-assigned this Jul 29, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020

Codecov Report

Merging #321 into ritchie-2.0.0 will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           ritchie-2.0.0     #321      +/-   ##
=================================================
+ Coverage          65.18%   65.29%   +0.10%     
=================================================
  Files                 78       78              
  Lines               2548     2550       +2     
=================================================
+ Hits                1661     1665       +4     
+ Misses               724      723       -1     
+ Partials             163      162       -1     
Impacted Files Coverage Δ
pkg/credential/finder.go 68.42% <100.00%> (+15.47%) ⬆️
pkg/credential/settings.go 86.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 816dc13...09a4993. Read the comment docs.

@viniciussousazup viniciussousazup added the 🚧 WIP Work in Progress label Jul 29, 2020
change DefaultCredentials names
@sandokandias sandokandias merged commit 50af162 into ZupIT:ritchie-2.0.0 Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚧 WIP Work in Progress 🔨 improvement Improvement in features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants