This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Fix/list credential #323
Merged
Fix/list credential #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-schumacher
requested review from
sandokandias,
kaduartur,
marcosgmgm,
marcoscostazup,
brunasilvazup and
lucasdittrichzup
Codecov Report
@@ Coverage Diff @@
## ritchie-2.0.0 #323 +/- ##
================================================
Coverage ? 65.24%
================================================
Files ? 78
Lines ? 2552
Branches ? 0
================================================
Hits ? 1665
Misses ? 725
Partials ? 162 Continue to review full report at Codecov.
|
| @@ -73,15 +73,17 @@ func formatCredential(credential string) string { | |||
|
|
|||
| return strings.Join(splitedCredential, "\"") | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I think this line stays, right?
There was a problem hiding this comment.
@brunasilvazup
Right. As it was already merged, i will add the line back on my next pull request. Thanks!
brunasilvazup
approved these changes
Jul 30, 2020
lucasdittrichzup
approved these changes
Jul 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
We change how the values of the credentials are shown;
Before, long credentials, in the worst case scenario, had 50% of them cut off, causing the wrong impression;
Now, we show the first 4 characters and hide the rest
- How to verify it
rit list credential;
You need a credential with more then 20 characters
- Description for the changelog
rit list credential improvement