Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Adding ansible credentials and bugfix for 2.0 #327

Conversation

henriquemoraes8
Copy link
Contributor

  • What I did

Adoption has been working on formulas for the API Manager team. One of them requires the provisioning of some hcl files to the cluster, which is done with Ansible. So it is being added to the pool of credentials

There was a bug in when adding a new credential provider, it would not be listed because the default credentials were only added if there was no config file. Upon further investigation, I think this file is not rewritten on updates as well. So the solution was to check a diff of the default credentials vs the current config.json file

  • How to verify it
    Run rit set credential and check for the existence of ansible option

  • Description for the changelog
    Added ansible support to rit set credential

@henriquemoraeszup henriquemoraeszup added 2.0.0 🪲 bug Report a bug encountered while operating Ritchie labels Jul 30, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2020

Codecov Report

Merging #327 into ritchie-2.0.0 will increase coverage by 0.88%.
The diff coverage is 73.38%.

Impacted file tree graph

@@                Coverage Diff                @@
##           ritchie-2.0.0     #327      +/-   ##
=================================================
+ Coverage          65.21%   66.09%   +0.88%     
=================================================
  Files                 78       78              
  Lines               2550     2572      +22     
=================================================
+ Hits                1663     1700      +37     
+ Misses               725      703      -22     
- Partials             162      169       +7     
Impacted Files Coverage Δ
pkg/cmd/build_formula.go 0.00% <0.00%> (ø)
pkg/cmd/root.go 0.00% <0.00%> (ø)
pkg/credential/finder.go 68.42% <ø> (ø)
pkg/formula/builder/bat.go 0.00% <0.00%> (ø)
pkg/formula/builder/local.go 72.54% <ø> (ø)
pkg/formula/formula.go 90.90% <ø> (ø)
pkg/formula/runner/post_run.go 50.00% <ø> (ø)
pkg/cmd/list_credential.go 80.00% <50.00%> (ø)
pkg/cmd/formulas.go 87.87% <57.14%> (-2.45%) ⬇️
pkg/credential/settings.go 82.64% <60.86%> (-3.77%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae92e1...e06bff1. Read the comment docs.

pkg/credential/settings.go Outdated Show resolved Hide resolved
pkg/credential/settings.go Outdated Show resolved Hide resolved
@henriquemoraeszup henriquemoraeszup added the 🚧 WIP Work in Progress label Jul 31, 2020
@henriquemoraeszup henriquemoraeszup removed the 🚧 WIP Work in Progress label Aug 4, 2020
@viniciussousazup viniciussousazup merged commit f74290c into ZupIT:ritchie-2.0.0 Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🪲 bug Report a bug encountered while operating Ritchie
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants