Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Improment PR guide lines #328

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Improment PR guide lines #328

merged 1 commit into from
Jul 30, 2020

Conversation

sandokandias
Copy link
Contributor

- What I did

As per the last meeting's presentation, I am updating the Contributing.md with some suggestion on how potential future codeowners might want to conduct pull reviews

- How to verify it

open Contributing.md

- Description for the changelog
Updated Contributing.md to include pull review guidelines

@sandokandias sandokandias changed the title merge from master Improment PR guide lines Jul 30, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #328 into ritchie-2.0.0 will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           ritchie-2.0.0     #328      +/-   ##
=================================================
+ Coverage          65.21%   65.24%   +0.02%     
=================================================
  Files                 78       78              
  Lines               2550     2552       +2     
=================================================
+ Hits                1663     1665       +2     
  Misses               725      725              
  Partials             162      162              
Impacted Files Coverage Δ
pkg/credential/finder.go 68.42% <ø> (ø)
pkg/credential/settings.go 84.76% <0.00%> (-1.65%) ⬇️
pkg/formula/watcher/watcher.go 76.47% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c05e32d...f831e60. Read the comment docs.

@sandokandias sandokandias merged commit 0ace450 into ZupIT:ritchie-2.0.0 Jul 30, 2020
@sandokandias sandokandias deleted the improvement/pr-guidelines branch July 30, 2020 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants