Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[FEATURE] Update go-cli-spinner lib #340

Merged
merged 1 commit into from
Jul 31, 2020
Merged

[FEATURE] Update go-cli-spinner lib #340

merged 1 commit into from
Jul 31, 2020

Conversation

kaduartur
Copy link
Contributor

- What I did

  • Increase go-cli-spinner version
  • Remove unused libs

- How to verify it

- Description for the changelog
Update go-cli-spinner lib

@kaduartur kaduartur added ✨ feature Suggest a new feature or enhancement to the Ritchie project 2.0.0 labels Jul 31, 2020
@kaduartur kaduartur self-assigned this Jul 31, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #340 into ritchie-2.0.0 will decrease coverage by 0.28%.
The diff coverage is 64.28%.

Impacted file tree graph

@@                Coverage Diff                @@
##           ritchie-2.0.0     #340      +/-   ##
=================================================
- Coverage          65.21%   64.93%   -0.29%     
=================================================
  Files                 78       78              
  Lines               2550     2555       +5     
=================================================
- Hits                1663     1659       -4     
- Misses               725      732       +7     
- Partials             162      164       +2     
Impacted Files Coverage Δ
pkg/cmd/build_formula.go 0.00% <0.00%> (ø)
pkg/cmd/root.go 0.00% <ø> (ø)
pkg/credential/finder.go 68.42% <ø> (ø)
pkg/credential/settings.go 84.76% <0.00%> (-1.65%) ⬇️
pkg/formula/builder/bat.go 0.00% <0.00%> (ø)
pkg/formula/builder/docker.go 0.00% <0.00%> (ø)
pkg/formula/builder/local.go 72.54% <ø> (ø)
pkg/formula/formula.go 90.90% <ø> (ø)
pkg/formula/runner/post_run.go 50.00% <ø> (ø)
pkg/cmd/formulas.go 87.87% <57.14%> (-2.45%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad6115c...80e6219. Read the comment docs.

Copy link
Contributor

@sandokandias sandokandias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaduartur kaduartur merged commit 1e28b40 into ZupIT:ritchie-2.0.0 Jul 31, 2020
@kaduartur kaduartur deleted the feature/update_spinner_lib branch July 31, 2020 23:21
@sandokandias
Copy link
Contributor

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Aug 3, 2020

👌 Merged branch feature/update_spinner_lib into qa

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants