Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Support gitlab provider on command add repo #350

Merged
merged 8 commits into from
Aug 5, 2020
Merged

Support gitlab provider on command add repo #350

merged 8 commits into from
Aug 5, 2020

Conversation

kaduartur
Copy link
Contributor

- What I did

  • Added new provider to add repo (Gitlab)
  • Separated git pkg in github and gitlab

- How to verify it

  • Add new repo with rit add repo
  • Run the unit tests with make unit-test command

- Description for the changelog
Add Gitlab provider to add repo

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2020

Codecov Report

Merging #350 into ritchie-2.0.0 will increase coverage by 0.07%.
The diff coverage is 59.78%.

Impacted file tree graph

@@                Coverage Diff                @@
##           ritchie-2.0.0     #350      +/-   ##
=================================================
+ Coverage          65.21%   65.28%   +0.07%     
=================================================
  Files                 78       80       +2     
  Lines               2550     2682     +132     
=================================================
+ Hits                1663     1751      +88     
- Misses               725      748      +23     
- Partials             162      183      +21     
Impacted Files Coverage Δ
pkg/cmd/build_formula.go 0.00% <0.00%> (ø)
pkg/cmd/root.go 0.00% <0.00%> (ø)
pkg/cmd/update_repo.go 0.00% <0.00%> (ø)
pkg/credential/finder.go 68.42% <ø> (ø)
pkg/credential/settings.go 84.76% <0.00%> (-1.65%) ⬇️
pkg/formula/builder/bat.go 0.00% <0.00%> (ø)
pkg/formula/builder/local.go 72.54% <ø> (ø)
pkg/formula/formula.go 90.90% <ø> (ø)
pkg/formula/repo.go 0.00% <0.00%> (ø)
pkg/formula/runner/post_run.go 50.00% <ø> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72f8483...c883631. Read the comment docs.

@kaduartur kaduartur self-assigned this Aug 4, 2020
@kaduartur kaduartur added 2.0.0 ✨ feature Suggest a new feature or enhancement to the Ritchie project labels Aug 4, 2020
@sandokandias sandokandias changed the title [FEATURE] Add Gitlab provider to add repo Support gitlab provider on command add repo Aug 5, 2020
Copy link
Contributor

@sandokandias sandokandias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@sandokandias sandokandias merged commit 83e4b9e into ZupIT:ritchie-2.0.0 Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants