Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[FEATURE] Create implementation to UserIdGenerator #379

Merged
merged 2 commits into from
Aug 10, 2020
Merged

[FEATURE] Create implementation to UserIdGenerator #379

merged 2 commits into from
Aug 10, 2020

Conversation

kaduartur
Copy link
Contributor

@kaduartur kaduartur commented Aug 7, 2020

- What I did

related #370

  • I created implementation to UserIdGenerator

- How to verify it

  • Run make unit-test

- Description for the changelog

@kaduartur kaduartur added ✨ feature Suggest a new feature or enhancement to the Ritchie project 2.0.0 labels Aug 7, 2020
@kaduartur kaduartur added this to the 2.0.4 milestone Aug 7, 2020
@kaduartur kaduartur self-assigned this Aug 7, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #379 into feature/metrics will increase coverage by 0.06%.
The diff coverage is 63.63%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feature/metrics     #379      +/-   ##
===================================================
+ Coverage            65.61%   65.67%   +0.06%     
===================================================
  Files                   80       81       +1     
  Lines                 2716     2727      +11     
===================================================
+ Hits                  1782     1791       +9     
  Misses                 750      750              
- Partials               184      186       +2     
Impacted Files Coverage Δ
pkg/metric/user_id_generator.go 63.63% <63.63%> (ø)
pkg/formula/watcher/watcher.go 76.47% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5adbf4e...1158671. Read the comment docs.

@brunasilvazup brunasilvazup self-requested a review August 7, 2020 20:19
@kaduartur kaduartur merged commit 2e5fb05 into ZupIT:feature/metrics Aug 10, 2020
@kaduartur kaduartur deleted the feature/user_id_generator branch August 10, 2020 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants