Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[FEATURE] add metrics command #394

Merged
merged 3 commits into from
Aug 10, 2020
Merged

[FEATURE] add metrics command #394

merged 3 commits into from
Aug 10, 2020

Conversation

victor-schumacher
Copy link
Contributor

@victor-schumacher victor-schumacher commented Aug 10, 2020

- What I did

A command used to turn on/off metrics

- How to verify it
rit metrics

- Description for the changelog
Adding metrics command

@victor-schumacher victor-schumacher requested review from kaduartur and sandokandias and removed request for kaduartur August 10, 2020 15:28
@victor-schumacher victor-schumacher self-assigned this Aug 10, 2020
@victor-schumacher victor-schumacher added the ✨ feature Suggest a new feature or enhancement to the Ritchie project label Aug 10, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2020

Codecov Report

Merging #394 into feature/metrics will increase coverage by 0.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feature/metrics     #394      +/-   ##
===================================================
+ Coverage            65.61%   66.10%   +0.49%     
===================================================
  Files                   80       81       +1     
  Lines                 2716     2750      +34     
===================================================
+ Hits                  1782     1818      +36     
+ Misses                 750      748       -2     
  Partials               184      184              
Impacted Files Coverage Δ
pkg/cmd/metrics.go 100.00% <100.00%> (ø)
pkg/formula/watcher/watcher.go 76.47% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f515a...ae6150c. Read the comment docs.

@victor-schumacher victor-schumacher changed the title add command add metrics command Aug 10, 2020
pkg/cmd/metrics.go Outdated Show resolved Hide resolved
@kaduartur kaduartur changed the title add metrics command [FEATURE] add metrics command Aug 10, 2020
@victor-schumacher victor-schumacher added this to the 2.0.4 milestone Aug 10, 2020
@victor-schumacher victor-schumacher linked an issue Aug 10, 2020 that may be closed by this pull request
Copy link
Contributor

@brunasilvazup brunasilvazup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

pkg/cmd/metrics.go Show resolved Hide resolved
@victor-schumacher victor-schumacher merged commit e6267dd into ZupIT:feature/metrics Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create new command "rit metrics"
4 participants