This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Metrics check #405
Merged
Metrics check #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/metrics #405 +/- ##
================================================
Coverage 66.35% 66.35%
================================================
Files 85 85
Lines 2803 2803
================================================
Hits 1860 1860
Misses 755 755
Partials 188 188 Continue to review full report at Codecov.
|
victor-schumacher
requested review from
kaduartur,
sandokandias,
lucasdittrichzup and
brunasilvazup
victor-schumacher
removed request for
sandokandias,
kaduartur,
brunasilvazup and
lucasdittrichzup
victor-schumacher
requested review from
kaduartur,
sandokandias,
lucasdittrichzup and
brunasilvazup
Hello, Could you add the explanatory texts for PR, please? |
Sure, I was forgetting it. Thanks. |
lucasdittrichzup
approved these changes
Aug 12, 2020
brunasilvazup
added
waiting reply
add mock for check metrics changed tests for metrics cmd change MetricsPath() function to a var called FilePath Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
victor-schumacher
added
✔️ ready-for-review
brunasilvazup
approved these changes
Aug 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added a check function which verifies metrics status
- How to verify it
Check and run the unit tests
- Description for the changelog
Added check function for metrics