Skip to content
This repository was archived by the owner on Jul 12, 2022. It is now read-only.

Collector function for metrics #429

Merged
merged 12 commits into from
Aug 18, 2020
Merged

Collector function for metrics #429

merged 12 commits into from
Aug 18, 2020

Conversation

victor-schumacher
Copy link
Contributor

@victor-schumacher victor-schumacher commented Aug 13, 2020 •
edited
Loading

- What I did
Added a Data collector function which gonna be used on metrics.

- How to verify it
Use the function or check the unit tests.

- Description for the changelog
Data collector function for metrics

@victor-schumacher
add checker
dc60b95 
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
@victor-schumacher
tests done
bde7b78 
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
@victor-schumacher
removed assert
840f157 
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
@victor-schumacher
fix vendor
cb963be 
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
@victor-schumacher
fix modules.txt
a6e3d8b 
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
@victor-schumacher
add json keys
d572446 
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020 •
edited
Loading

Codecov Report

Merging #429 into feature/metrics will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feature/metrics     #429      +/-   ##
===================================================
+ Coverage            66.59%   66.83%   +0.23%     
===================================================
  Files                   86       87       +1     
  Lines                 2826     2846      +20     
===================================================
+ Hits                  1882     1902      +20     
  Misses                 753      753              
  Partials               191      191
Impacted Files Coverage Δ
pkg/metric/metric.go 100.00% <ø> (ø)
pkg/metric/data_collector.go 100.00% <100.00%> (ø)
pkg/metric/grpc_sender.go 100.00% <100.00%> (ø)
pkg/metric/http_sender.go 69.23% <100.00%> (ø)
pkg/version/version.go 88.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f380b5...fbfc41f. Read the comment docs.

@victor-schumacher victor-schumacher linked an issue Aug 13, 2020 that may be closed by this pull request
[FEATURE] Collect commands metrics #368
Closed
@victor-schumacher victor-schumacher added this to the 2.0.4 milestone Aug 13, 2020
@victor-schumacher victor-schumacher self-assigned this Aug 13, 2020
@brunasilvazup brunasilvazup added ✨ feature Suggest a new feature or enhancement to the Ritchie project waiting reply Waiting for an answer to a comment and removed ✔️ ready-for-review ready for review labels Aug 14, 2020
@victor-schumacher victor-schumacher changed the title Feature/data collect Collector function for metrics Aug 14, 2020
@victor-schumacher
change variable name
6c8fb24 
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
@victor-schumacher victor-schumacher added ✔️ ready-for-review ready for review and removed waiting reply Waiting for an answer to a comment labels Aug 14, 2020
brunasilvazup
brunasilvazup approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@brunasilvazup brunasilvazup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

kaduartur
kaduartur suggested changes Aug 14, 2020
View reviewed changes
kaduartur
kaduartur approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@kaduartur kaduartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best! 🚀

@victor-schumacher victor-schumacher merged commit 6719fe5 into ZupIT:feature/metrics Aug 18, 2020
@victor-schumacher victor-schumacher deleted the feature/dataCollect branch August 18, 2020 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaduartur kaduartur kaduartur approved these changes

@brunasilvazup brunasilvazup brunasilvazup approved these changes

@lucasdittrichzup lucasdittrichzup lucasdittrichzup approved these changes

Assignees

@victor-schumacher victor-schumacher

Labels
✔️ ready-for-review ready for review ✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
None yet
Milestone
2.0.4
Development

Successfully merging this pull request may close these issues.

[FEATURE] Collect commands metrics
5 participants
@victor-schumacher @codecov-commenter @kaduartur @brunasilvazup @lucasdittrichzup