-
Notifications
You must be signed in to change notification settings - Fork 102
Add stdin validation for docker execution #493
Conversation
Signed-off-by: GuillaumeFalourd <guillaume.falourd@zup.com.br>
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
=======================================
Coverage 74.74% 74.74%
=======================================
Files 95 95
Lines 3184 3184
=======================================
Hits 2380 2380
Misses 640 640
Partials 164 164
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a pr in qa that will change a lot about the runner > #480
I recommend that you wait and assess whether the error will persist.
I've checked the PR @brunasilvazup and this problem hasn't been resolved there. I can eventually update Kadu's branch with that correction if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/merge qa |
🔥 Merge Conflict |
/merge qa |
👌 Merged branch bug/stdin-docker into qa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in qa, the error has been fixed 👍
Signed-off-by: GuillaumeFalourd guillaume.falourd@zup.com.br
- What I did
- How to verify it
- Description for the changelog