Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Added changes suggested by goimports #509

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

brunats
Copy link
Contributor

@brunats brunats commented Sep 9, 2020

- What I did
Hi Ritchiers,

In the search for improving the quality of the code I decided to open a PR by passing the goimports in the project.

Adds all suggested changes (and revised one by one) to the project.

- How to verify it

Clone this pr with the command

git fetch upstream pull/509/head:improvement/updates-linters

And run goimports

git checkout master
goimports -w $(find . -type f -name '*.go' -not -path "./vendor/*") # Check the differences generated
git checkout improvement/updates-linters
goimports -w $(find . -type f -name '*.go' -not -path "./vendor/*") # Check the differences

- Description for the changelog

Improves code quality related to linter goimport.

Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
@brunasilvazup brunasilvazup added 🚧 WIP Work in Progress 🔨 improvement Improvement in features labels Sep 9, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #509 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
+ Coverage   76.27%   76.31%   +0.04%     
==========================================
  Files          95       95              
  Lines        3199     3205       +6     
==========================================
+ Hits         2440     2446       +6     
  Misses        593      593              
  Partials      166      166              
Impacted Files Coverage Δ
pkg/credential/credential.go 0.00% <ø> (ø)
pkg/formula/builder/bat.go 0.00% <ø> (ø)
pkg/formula/formula.go 90.90% <ø> (ø)
pkg/metric/checker.go 100.00% <ø> (ø)
pkg/metric/user_id_generator.go 63.63% <ø> (ø)
pkg/rcontext/remover.go 68.42% <ø> (ø)
pkg/upgrade/url_finder.go 100.00% <ø> (ø)
pkg/cmd/set_context.go 48.64% <100.00%> (ø)
pkg/cmd/upgrade.go 100.00% <100.00%> (ø)
pkg/formula/runner/inputs.go 98.18% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0afa518...207eaf7. Read the comment docs.

Copy link
Contributor

@victor-schumacher victor-schumacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

"strings"

"github.com/ZupIT/ritchie-cli/pkg/file/fileutil"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@lucasdittrichzup
Copy link
Contributor

🚀

@brunasilvazup
Copy link
Contributor

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Sep 10, 2020

👌 Merged branch improvement/updates-linters into qa

@brunasilvazup brunasilvazup added 🚀 QA and removed ✔️ ready-for-review ready for review labels Sep 10, 2020
@brunasilvazup brunasilvazup merged commit ebceb3a into ZupIT:master Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔨 improvement Improvement in features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants