Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Added tests to update repo command #515

Merged

Conversation

brunats
Copy link
Contributor

@brunats brunats commented Sep 10, 2020

- What I did
Hi Ritchiers,
Add tests for the rit update repo command

Master
master
->
PR
pr

- How to verify it

Clone this pr with the command

git fetch upstream pull/515/head:improvement/added-tests-to-update-repo-command

And run goimports

git checkout master
make build && cp dist/linux/rit /usr/local/bin/
go test -v -failfast -short -coverprofile=bin/cov.out ./pkg/cmd && go tool cover -func=bin/cov.out # Run unit tests of the cmd pkg

git checkout improvement/added-tests-to-update-repo-command
make build && cp dist/linux/rit /usr/local/bin/
go test -v -failfast -short -coverprofile=bin/cov.out ./pkg/cmd && go tool cover -func=bin/cov.out #  Run and see the differences

- Description for the changelog

Added tests to update repo command

Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
…ub.com:brunats/ritchie-cli into improvement/added-tests-to-update-repo-command
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
…ent/added-tests-to-update-repo-command

Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
…ent/added-tests-to-update-repo-command

Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2020

Codecov Report

Merging #515 into master will increase coverage by 0.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   77.60%   78.15%   +0.54%     
==========================================
  Files          95       95              
  Lines        3260     3204      -56     
==========================================
- Hits         2530     2504      -26     
+ Misses        559      534      -25     
+ Partials      171      166       -5     
Impacted Files Coverage Δ
pkg/cmd/update_repo.go 100.00% <100.00%> (+27.84%) ⬆️
pkg/formula/watcher/watcher.go 70.58% <0.00%> (-5.89%) ⬇️
pkg/cmd/list_repo.go 95.00% <0.00%> (+11.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a15b1f...ffd4a07. Read the comment docs.

Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
@brunasilvazup brunasilvazup changed the title Improvement/added tests to update repo command Added tests to update repo command Sep 11, 2020
@brunasilvazup brunasilvazup requested review from kaduartur and victor-schumacher and removed request for kaduartur September 11, 2020 14:39
@brunasilvazup brunasilvazup added ✔️ ready-for-review ready for review 🔨 improvement Improvement in features labels Sep 11, 2020
pkg/cmd/update_repo.go Outdated Show resolved Hide resolved
pkg/cmd/update_repo_test.go Show resolved Hide resolved
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
…ent/added-tests-to-update-repo-command

Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
@kaduartur kaduartur merged commit cb905f2 into ZupIT:master Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔨 improvement Improvement in features ✔️ ready-for-review ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants