Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Displays error when invalid argument added to command #530

Conversation

brunats
Copy link
Contributor

@brunats brunats commented Sep 16, 2020

- What I did

Added validation of arguments in commands, commands 'leaf' (don't have subcommands) presents an error when other arguments are informed.

aa

- How to verify it

Clone this pr with the command

git fetch upstream pull/530/head:fix/displays-error-when-invalid-argument-added-to-command

And run commands with invalid arguments

git checkout fix/displays-error-when-invalid-argument-added-to-command
make build && cp dist/linux/rit /usr/local/bin/

rit list repo ritchie #  Run and see error
rit list repo #  Run

rit list # Run and see the suggestions

- Description for the changelog

Displays error when invalid argument added to command

Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
…mmand

Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
@brunasilvazup brunasilvazup added the 🚧 WIP Work in Progress label Sep 16, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2020

Codecov Report

Merging #530 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   79.23%   79.23%           
=======================================
  Files          96       96           
  Lines        4157     4157           
=======================================
  Hits         3294     3294           
  Misses        641      641           
  Partials      222      222           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5973d5e...c0d6bea. Read the comment docs.

Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
…lays-error-when-invalid-argument-added-to-command

Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
@brunasilvazup brunasilvazup changed the title Fix/displays error when invalid argument added to command Displays error when invalid argument added to command Sep 16, 2020
@brunasilvazup brunasilvazup linked an issue Sep 16, 2020 that may be closed by this pull request
@brunasilvazup brunasilvazup added ✔️ ready-for-review ready for review and removed 🚧 WIP Work in Progress labels Sep 17, 2020
@brunasilvazup brunasilvazup added the 🪲 bug Report a bug encountered while operating Ritchie label Sep 17, 2020
@brunasilvazup brunasilvazup merged commit 1c336ec into ZupIT:master Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🪲 bug Report a bug encountered while operating Ritchie ✔️ ready-for-review ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command line validation
5 participants