Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Add support to the tutorial field in config.json #534

Merged
merged 6 commits into from
Sep 21, 2020
Merged

Add support to the tutorial field in config.json #534

merged 6 commits into from
Sep 21, 2020

Conversation

kaduartur
Copy link
Contributor

- What I did

  • I added support to the tutorial field in config.json
    Example:
[
  {
    "name": "sample_text",
    "type": "text",
    "label": "Type : ",
    "cache": {
      "active": true,
      "qty": 6,
      "newLabel": "Type new value. "
    },
    "tutorial": "Add a text for this field."
  },
  {
    "name": "sample_text",
    "type": "text",
    "label": "Type : ",
    "default": "test"
  },
  {
    "name": "sample_list",
    "type": "text",
    "default": "in1",
    "items": [
      "in_list1",
      "in_list2",
      "in_list3",
      "in_listN"
    ],
    "cache": {
      "active": true,
      "qty": 3,
      "newLabel": "Type new value?"
    },
    "label": "Pick your : ",
    "tutorial": "Select an item for this field."
  },
  {
    "name": "sample_bool",
    "type": "bool",
    "default": "false",
    "items": [
      "false",
      "true"
    ],
    "label": "Pick: ",
    "tutorial": "Select true or false for this field."
  },
  {
    "name": "sample_password",
    "type": "password",
    "label": "Pick: ",
    "tutorial": "Add a secret password for this field."
  }
]

- How to verify it
You can build this branch and add in the config.json the tutorial field.

- Description for the changelog
Support to the tutorial field in config.json

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
@kaduartur kaduartur added ✨ feature Suggest a new feature or enhancement to the Ritchie project ✔️ ready-for-review ready for review labels Sep 18, 2020
@kaduartur kaduartur self-assigned this Sep 18, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2020

Codecov Report

Merging #534 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   78.24%   78.24%           
=======================================
  Files          96       96           
  Lines        3098     3098           
=======================================
  Hits         2424     2424           
  Misses        494      494           
  Partials      180      180           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c336ec...d482415. Read the comment docs.

@kaduartur kaduartur linked an issue Sep 18, 2020 that may be closed by this pull request
@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Sep 21, 2020

🔥 Merge Conflict

@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Sep 21, 2020

👌 Merged branch feature/tutorial_field-config.json into qa

@kaduartur kaduartur added 🚀 QA and removed ✔️ ready-for-review ready for review labels Sep 21, 2020
@kaduartur kaduartur merged commit e5c07c3 into ZupIT:master Sep 21, 2020
@kaduartur kaduartur deleted the feature/tutorial_field-config.json branch September 21, 2020 16:20
@GuillaumeFalourd
Copy link
Contributor

Great feature, thanks !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a tutorial field to the config.json file
5 participants